Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 74: enforcing reactive power limits for AC power flow #76

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

GabrielKS
Copy link
Contributor

Fixes #74:

  • Filters out kwargs that shouldn't be passed along to NLSolve
  • Updates the System with changes that aren't captured in the solver results

@rbolgaryn @annacasavant tagging for visibility, don't necessarily need a review from you.

@GabrielKS GabrielKS self-assigned this Jan 11, 2025
@GabrielKS GabrielKS added the bug Something isn't working label Jan 11, 2025
Copy link
Collaborator

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@jd-lara jd-lara merged commit 03a1e05 into main Jan 14, 2025
6 checks passed
@GabrielKS GabrielKS mentioned this pull request Jan 15, 2025
@GabrielKS GabrielKS linked an issue Jan 16, 2025 that may be closed by this pull request
@jd-lara jd-lara deleted the gks/fix_74 branch January 16, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solving/Updating PowerFlow & check reactive power limits Filter kwargs for NLSolve
3 participants