fix/remove-loaded-empty -- removes _loaded and _empty fields from rail vehicle
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than `_empty` and `_loaded` fields
calbaker
changed the title
_loaded and _empty fields from rail vehicle
python unit tests pass some functional tests fail
Runing `python speed_limit_train_sim_demo.py` yields:
Traceback (most recent call last):
File "/Users/cbaker2/Documents/github/altrios/python/altrios/demos/speed_limit_train_sim_demo.py", line 77, in <module>
train_sim: alt.SpeedLimitTrainSim = tsb.make_speed_limit_train_sim(
RuntimeError: [altrios-core/src/train/train_config.rs:644]
Caused by:
Extra values in `n_cars_by_type` that are not in `car_type`: ["Manifest_Empty", "stivelrlydt"]
running `python speed_limit_simple_corr_demo.py` yields:
Traceback (most recent call last):
File "/Users/cbaker2/Documents/github/altrios/python/altrios/demos/speed_limit_simple_corr_demo.py", line 73, in <module>
train_sim: alt.SetSpeedTrainSim = tsb.make_speed_limit_train_sim(
RuntimeError: [altrios-core/src/train/train_config.rs:647]
Caused by:
[altrios-core/src/train/train_config.rs:163]
Expected `self.n_cars_by_type` to contain 'Manifest_Empty'
made it so logging feature is enabled but logging must be activated
mbbruch
reviewed
Sep 5, 2024
| bail!("`set_mass` is not enabled for `RailVehicle`") | ||
| } | ||
|
|
||
| fn derived_mass(&self) -> anyhow::Result<Option<si::Mass>> { |
There was a problem hiding this comment.
When we size locomotive consists in the train planner, we also include axle_count * mass_extra_per_axle_kilograms when estimating mass. Just flagging to confirm we don't need to harmonize across the code?
There was a problem hiding this comment.
@mbbruch, that should be correct, and right now, I don't think there is a cleaner way to do this. I think there is room for improvement that we should discuss, but I think that can come later.
mbbruch
reviewed
Sep 5, 2024
because friction brakes now have to handle rotational mass, too
mbbruch
approved these changes
Sep 9, 2024
FDsteven
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
rail_vehicles: Vec<RailVehicle>is now an input toTrainConfig::new()rail_vehicleis no longer needed as input tomake_.*_train_simmake_.*_train_sim_partsis now a thing for getting intermediate objects for inspectionTODO
Masstrait to train stuff, where appropriate -- @calbaker