-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engage75 change user #232
base: dev
Are you sure you want to change the base?
Engage75 change user #232
Conversation
calliope_app/account/views.py
Outdated
@@ -1,4 +1,5 @@ | |||
import json | |||
# from ..client.views import common_timezones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
These changes don't reflect the mockup, but looking at the user pages again I don't think there's a need to combine the change password page and the user detail page. Seems ideal to keep them separate and I forget the context of that thought process. Maybe just add the ability for them to edit fist name and last name as well and call it good if James/Tom agree? |
Confirmed with Jordan today, he's going to add first and last name editability to this and make a separate ticket to add email notifications down the line. Keeping the change password page separate. |
Here's what I saw on my local with this PR, What could be updated by the user?
Be careful about the So on UI, to change Username to Email. If the email got changed, need to validate the email. |
Fixed! |
@jeisenman23 Did you push your update to the branch? I pulled, but no changes. |
Oh no, I accidentally pushed my changes to the wrong branch. |
Just migrated the changes! |
Thanks for the update. Some other places that I think need update.
2 - Prettify the form UI of the page 3 - Add As a user, I want to Add 4 - Email update error if the email already exists in Engage.
5 - Update some of the logic I changed my email to a fake one
|
No description provided.