Reformatted investigator headers and graph pages #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 18, 2012 13:20
…tial. - Made minor terminology changes to better match the headers and the links. - Added a header where necessary. - Moved the code for the graphs navigation bar to a partial. - Collapsed the `investigator_bio_heading` functions into a partial. - Made extensive use of `current_page?` to determine how to show the current page's link. `current_page?` should be helpful later on. Considerations: Cons: It's vaguely magical and possibly a bit slower. I don't like the magic. Pros: Its output is cached anyway, according to profiling it contributes less than 4% of the template rendering time, and it lets you generate URLs however you like.
- Took out the bar chart for Org Collaboration Network. It didn't really seem consistent with any of the other ones... - A somewhat questionable change to move the sparklines. I personally think it looks more consistent next to the publications.
Added code to publications.css -- it should be available site-wide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
These commits:
Let me know if there are any issues.