Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: example job using EKS jumphost #1151

Merged
merged 3 commits into from
Dec 6, 2024
Merged

CI: example job using EKS jumphost #1151

merged 3 commits into from
Dec 6, 2024

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Nov 12, 2024

No description provided.

.github/workflows/_ci.yaml Outdated Show resolved Hide resolved
.github/workflows/_ci.yaml Show resolved Hide resolved
.github/workflows/_ci.yaml Outdated Show resolved Hide resolved
yhtang
yhtang previously approved these changes Dec 3, 2024
Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the headless service is not deleted when the job finishes. You should be able to easily fix it though.

@yhtang yhtang merged commit ccabd0e into main Dec 6, 2024
150 of 173 checks passed
@yhtang yhtang deleted the olupton/eks branch December 6, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants