Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nccl-tests-on-k8s logic into a reusable workflow #1233

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jan 9, 2025

main counterpart of 25.01-devel's #1234

@olupton olupton marked this pull request as ready for review January 9, 2025 14:05
@olupton olupton force-pushed the olupton/reusable-k8s-nccl branch from b26145d to ee2d148 Compare January 9, 2025 14:06
@olupton olupton requested review from yhtang and DwarKapex January 10, 2025 11:09
olupton added a commit that referenced this pull request Jan 13, 2025
@olupton olupton requested a review from Steboss January 15, 2025 15:59
Copy link
Contributor

@Steboss Steboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olupton olupton merged commit 7036e87 into main Jan 15, 2025
162 of 181 checks passed
@olupton olupton deleted the olupton/reusable-k8s-nccl branch January 15, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants