Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run MaxText tests on AWS with NGC release candidate images #1237

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jan 9, 2025

No description provided.

@olupton olupton requested a review from gpupuck January 10, 2025 09:58
gpupuck
gpupuck previously approved these changes Jan 10, 2025
Copy link
Contributor

@gpupuck gpupuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from olupton/reusable-k8s-nccl-25.01 to 25.01-devel January 13, 2025 17:22
@olupton olupton dismissed gpupuck’s stale review January 13, 2025 17:22

The base branch was changed.

@olupton olupton force-pushed the olupton/eks-maxtext-25.01 branch from 15b7a58 to 481e71b Compare January 13, 2025 17:35
Copy link
Contributor

@Steboss Steboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but great work!

.github/workflows/_test_maxtext_k8s.yaml Show resolved Hide resolved
.github/workflows/_test_maxtext_k8s.yaml Show resolved Hide resolved
@olupton olupton merged commit b0ec72a into 25.01-devel Jan 16, 2025
123 of 139 checks passed
@olupton olupton deleted the olupton/eks-maxtext-25.01 branch January 16, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants