Add feature to build rosetta with custom patches provided thru the web UI #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b UI This should help test changes more quickly since an ephemeral branch is no longer needed. One pain point before this change is you would have to create a branch using a mirror-branch with the staged test, and after the test succeeds, you would need to clean up your ephemeral branch that referenced the mirror-branch.
terrykong
force-pushed
the
custom-patches
branch
from
f96338a to
bf29630
Compare
yhtang
requested changes
Nov 7, 2023
|
In this workflow:
this change would simplify (3) and (5) since you no longer need to create a branch just for testing. All patches should still be present in the patchlists in version control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help test changes more quickly since an ephemeral branch is no longer needed. One pain point before this change is you would have to create a branch using a mirror-branch with the staged test, and after the test succeeds, you would need to clean up your ephemeral branch that referenced the mirror-branch.