Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nvcr.io private registry to stage CI internal containers #76

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use nvcr.io private registry to stage CI internal containers #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cae7e9
use nvcr.io for staging ingernal CI/CD containers
yhtang May 21, 2023
dab0e7d
fix job step names
yhtang May 22, 2023
ad78500
pass nvcr.io token to SLURM job
yhtang May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/_build_base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:
value: ${{ jobs.build.outputs.DOCKER_TAGS }}

env:
UPLD_IMAGE: ghcr.io/nvidia/jax-toolbox-internal
UPLD_IMAGE: nvcr.io/nvidian/jax-toolbox-internal

permissions:
contents: read # to fetch code
Expand All @@ -39,12 +39,12 @@ jobs:
- name: Check out the repository under ${GITHUB_WORKSPACE}
uses: actions/checkout@v3

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Set docker metadata
id: meta
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/_build_jax.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ on:
value: ${{ jobs.build.outputs.DOCKER_TAGS }}

env:
UPLD_IMAGE: ghcr.io/nvidia/jax-toolbox-internal
UPLD_IMAGE: nvcr.io/nvidian/jax-toolbox-internal

permissions:
contents: read # to fetch code
Expand All @@ -59,12 +59,12 @@ jobs:
- name: Check out the repository under ${GITHUB_WORKSPACE}
uses: actions/checkout@v3

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Set docker metadata
id: meta
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/_build_pax.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ on:
value: ${{ jobs.build.outputs.DOCKER_TAGS }}

env:
UPLD_IMAGE: ghcr.io/nvidia/jax-toolbox-internal
UPLD_IMAGE: nvcr.io/nvidian/jax-toolbox-internal

permissions:
contents: read # to fetch code
Expand All @@ -59,12 +59,12 @@ jobs:
- name: Check out the repository under ${GITHUB_WORKSPACE}
uses: actions/checkout@v3

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Set docker metadata
id: meta
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/_build_rosetta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
value: ${{ jobs.build.outputs.DOCKER_TAGS }}

env:
UPLD_IMAGE: ghcr.io/nvidia/jax-toolbox-internal
UPLD_IMAGE: nvcr.io/nvidian/jax-toolbox-internal
DOCKER_REGISTRY: ghcr.io/nvidia

permissions:
Expand Down Expand Up @@ -52,12 +52,12 @@ jobs:
- name: Check out the repository under ${GITHUB_WORKSPACE}
uses: actions/checkout@v3

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Set docker metadata
id: meta
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/_build_t5x.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:
value: ${{ jobs.build.outputs.DOCKER_TAGS }}

env:
UPLD_IMAGE: ghcr.io/nvidia/jax-toolbox-internal
UPLD_IMAGE: nvcr.io/nvidian/jax-toolbox-internal

permissions:
contents: read # to fetch code
Expand All @@ -49,12 +49,12 @@ jobs:
- name: Check out the repository under ${GITHUB_WORKSPACE}
uses: actions/checkout@v3

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Set docker metadata
id: meta
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/_build_te.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:
value: ${{ jobs.build.outputs.DOCKER_TAGS }}

env:
UPLD_IMAGE: ghcr.io/nvidia/jax-toolbox-internal
UPLD_IMAGE: nvcr.io/nvidian/jax-toolbox-internal

permissions:
contents: read # to fetch code
Expand All @@ -49,12 +49,12 @@ jobs:
- name: Check out the repository under ${GITHUB_WORKSPACE}
uses: actions/checkout@v3

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Set docker metadata
id: meta
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/_publish_nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ jobs:
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Set docker metadata
id: meta
uses: docker/metadata-action@v4
Expand All @@ -48,8 +55,9 @@ jobs:
shell: bash -x -e {0}
run: |
for tag in $(echo "${{ steps.meta.outputs.tags }}"); do
docker manifest create $tag ${{ inputs.SOURCE_IMAGE }}
docker manifest push $tag
docker pull ${{ inputs.SOURCE_IMAGE }}
docker tag ${{ inputs.SOURCE_IMAGE }} $tag
docker push $tag
done

- name: Generate outputs and artifacts
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/_sandbox.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ jobs:
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: nvcr.io
username: $oauthtoken
password: ${{ secrets.NVCR_TOKEN }}

- name: Print usage
run: |
cat << EOF
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/_test_jax.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ jobs:
- name: Print GPU information
run: nvidia-smi

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Pull JAX image
shell: bash -x -e {0}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_test_pax.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
#SBATCH --tasks-per-node=${{ steps.meta.outputs.GPUS_PER_NODE }}
#SBATCH --time=00:30:00
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
#SBATCH --export="VOCAB_PATH=gs://t5-data/vocabs/cc_all.32000.100extra/sentencepiece.model,ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }},NVCR_TOKEN=$${{ secrets.NVCR_TOKEN }}"
time srun \
--container-image=${{ steps.meta.outputs.IMAGE }} \
--container-mounts=${{ steps.meta.outputs.MODEL_PATH }}:/output \
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/_test_rosetta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ jobs:
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Pull Rosetta image
shell: bash -x -e {0}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/_test_t5x.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
#SBATCH --gpus-per-node=${{ matrix.N_GPU }}
#SBATCH --time=00:30:00
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }},NVCR_TOKEN=$${{ secrets.NVCR_TOKEN }}"
time srun \
--container-image=${{ steps.meta.outputs.IMAGE }} \
--container-mounts=${{ steps.meta.outputs.MODEL_PATH }}:/output \
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
#SBATCH --tasks-per-node=${{ matrix.N_GPU }}
#SBATCH --time=00:30:00
#SBATCH --output=${{ steps.meta.outputs.LOG_FILE }}
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }}"
#SBATCH --export="ENROOT_PASSWORD=${{ secrets.GITHUB_TOKEN }},NVCR_TOKEN=$${{ secrets.NVCR_TOKEN }}"
time srun \
--container-image=${{ steps.meta.outputs.IMAGE }} \
--container-mounts=${{ steps.meta.outputs.MODEL_PATH }}:/output \
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/_test_te.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ jobs:
- name: Print GPU information
run: nvidia-smi

- name: Login to GitHub Container Registry
- name: Login to NVIDIA Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: nvcr.io
username: '$oauthtoken'
password: ${{ secrets.NVCR_TOKEN }}

- name: Pull JAX-TE image
shell: bash -x -e {0}
Expand Down