Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pedantic spelling #1085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pedantic spelling #1085

wants to merge 1 commit into from

Conversation

dltemple
Copy link

@dltemple dltemple commented Jan 19, 2025

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Please ensure you are submitting from a unique branch in your repository to main upstream.

Verification

List the steps needed to make sure this thing works

  • Supporting configuration such as generator configuration file
{
    "huggingface": {
        "torch_type": "float32"
    }
}
  • garak -m <model_type> -n <model_name>
  • Run the tests and ensure they pass python -m pytest tests/
  • ...
  • Verify the thing does what it should
  • Verify the thing does not do what it should not
  • Document the thing and how it works (Example)

If you are opening a PR for a new plugin that targets a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us as much detail as possible.

Specific Hardware Examples:

  • GPU related
    • Specific support required cuda / mps ( Please not cuda via ROCm if related )
    • Minium GPU Memory

Complex Software Examples:

  • Expensive proprietary software
  • Software with an extensive installation process
  • Software without an English language UI

Copy link
Contributor

github-actions bot commented Jan 19, 2025

DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅

@dltemple
Copy link
Author

I have read the DCO Document and I hereby sign the DCO

@dltemple
Copy link
Author

recheck

github-actions bot added a commit that referenced this pull request Jan 19, 2025
| realtoxicityprompts | Subset of the RealToxicityPrompts work (data constrained because the full test will take so long to run) |
| snowball | [Snowballed Hallucination](https://ofir.io/snowballed_hallucination.pdf) probes designed to make a model give a wrong answer to questions too complex for it to process |
| xss | Look for vulnerabilities the permit or enact cross-site attacks, such as private data exfiltration. |
| Probe | Description |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format table so it presents as intended when not in preview mode

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I understand the idea here and readable markdown is a good practice, in this case I would say the extra formatting in the second column does not really add value as many editors and raw viewers will wrap lines longer than 120 characters or wider than the terminal or window view.

@leondz @erickgalinkin any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants