Make app robust to scsb api issues #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that, if connecting to the SCSB API raises an error or responds unexpectedly when querying for item statuses, we set offsite item statuses to 'Not available' and proceed with other work. Includes light refactoring to improve readability https://jira.nypl.org/browse/SCC-4050
nonword
commented
May 8, 2024
|
|
||
| if (!Array.isArray(itemsStatus)) { | ||
| logger.warn(`Got bad itemAvailabilityStatus response from SCSB for barcodes (${barcodes}): ${JSON.stringify(itemsStatus)}`) | ||
| return {} |
There was a problem hiding this comment.
The validation and early return {} instances are the main functional change here. They ensure that, if anything unexpected happens in the scsb call, the barcode-to-status mapping is returned as {}, causing ReCAP items to default to na status.
danamansana
approved these changes
May 15, 2024
charmingduchess
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that, if connecting to the SCSB API raises an error or responds unexpectedly when querying for item statuses, we set offsite item statuses to 'Not available' and proceed with other work.
Includes light refactoring to improve readability
https://jira.nypl.org/browse/SCC-4050