Skip to content

Commit

Permalink
fix(build): missing version upgrade and types (#3305)
Browse files Browse the repository at this point in the history
## Changes

- Publish did not properly upgrade all the versions 
I don't know why yet, the logs seems correct
https://github.com/NangoHQ/nango/actions/runs/12769711620
Maybe there was a delay publishing some package and npm install did not
yield an upgrade

---

While digging 

- Fix types installed as prod deps
- Fix incorrect webhooks tsconfig
- Fix missing types in the main tsconfig 
Typescript is really forgiving :D
  • Loading branch information
bodinsamuel authored Jan 14, 2025
1 parent 72b93dc commit 145f7eb
Show file tree
Hide file tree
Showing 10 changed files with 32 additions and 274 deletions.
273 changes: 9 additions & 264 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@babel/parser": "^7.22.5",
"@babel/traverse": "^7.22.5",
"@babel/types": "^7.22.5",
"@nangohq/nango-yaml": "0.48.1",
"@nangohq/nango-yaml": "0.48.2",
"@nangohq/shared": "^0.48.2",
"@swc/core": "^1.5.25",
"ajv": "^8.17.1",
Expand Down Expand Up @@ -55,7 +55,7 @@
"@babel/core": "^7.22.1",
"@babel/preset-env": "^7.22.4",
"@babel/preset-typescript": "^7.21.5",
"@nangohq/types": "0.48.1",
"@nangohq/types": "0.48.2",
"@types/babel__traverse": "^7.20.1",
"@types/babel-traverse": "^6.25.7",
"@types/commander": "^2.12.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"license": "SEE LICENSE IN LICENSE FILE IN GIT REPOSITORY",
"scripts": {},
"devDependencies": {
"@nangohq/types": "0.48.1"
"@nangohq/types": "0.48.2"
},
"files": [
"dist/**/*.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/nango-yaml/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"ms": "3.0.0-canary.1"
},
"devDependencies": {
"@nangohq/types": "0.48.1",
"@nangohq/types": "0.48.2",
"vitest": "2.1.8"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/node-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"README.md"
],
"devDependencies": {
"@nangohq/types": "0.48.1",
"@nangohq/types": "0.48.2",
"tsup": "^8.2.4",
"vitest": "2.1.8"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/persist/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@
"@nangohq/logs": "file:../logs",
"@nangohq/records": "file:../records",
"@nangohq/shared": "file:../shared",
"@nangohq/types": "file:../types",
"@nangohq/utils": "file:../utils",
"dd-trace": "5.21.0",
"express": "^4.20.0",
"zod": "3.24.1"
},
"devDependencies": {
"@nangohq/types": "file:../types",
"@types/node": "20.12.2",
"node-fetch": "^3.3.2",
"typescript": "5.7.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"@nangohq/nango-yaml": "file:../nango-yaml",
"@nangohq/records": "file:../records",
"@nangohq/shared": "file:../shared",
"@nangohq/types": "file:../types",
"@nangohq/utils": "file:../utils",
"@nangohq/webhooks": "file:../webhooks",
"@nangohq/keystore": "file:../keystore",
Expand Down Expand Up @@ -65,6 +64,7 @@
"zod": "3.24.1"
},
"devDependencies": {
"@nangohq/types": "file:../types",
"@types/cookie-parser": "1.4.3",
"@types/cors": "2.8.12",
"@types/express": "4.17.13",
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@datadog/datadog-api-client": "1.26.0",
"@hapi/boom": "^10.0.1",
"@nangohq/database": "file:../database",
"@nangohq/nango-yaml": "0.48.1",
"@nangohq/nango-yaml": "0.48.2",
"@nangohq/node": "^0.48.2",
"@nangohq/utils": "file:../utils",
"ajv": "^8.17.1",
Expand Down Expand Up @@ -54,7 +54,7 @@
"devDependencies": {
"@nangohq/logs": "file:../logs",
"@nangohq/nango-orchestrator": "file:../orchestrator",
"@nangohq/types": "0.48.1",
"@nangohq/types": "0.48.2",
"@types/braintree": "^3.3.12",
"@types/js-yaml": "^4.0.5",
"@types/json-schema": "7.0.15",
Expand Down
12 changes: 11 additions & 1 deletion packages/webhooks/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@
"rootDir": "lib",
"outDir": "dist"
},
"references": [{ "path": "../utils", "path": "../logs" }],
"references": [
{
"path": "../utils"
},
{
"path": "../logs"
},
{
"path": "../types"
}
],
"include": ["lib/**/*", "../utils/lib/vitest.d.ts"]
}
3 changes: 3 additions & 0 deletions tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@
},
{
"path": "packages/fleet"
},
{
"path": "packages/types"
}
]
}

0 comments on commit 145f7eb

Please sign in to comment.