Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/master' into 12-31-add_integra…
Browse files Browse the repository at this point in the history
…tions_with_readwise_apis
  • Loading branch information
sarimabbas committed Jan 11, 2025
2 parents f50b432 + 40f3b0d commit c3582ef
Show file tree
Hide file tree
Showing 383 changed files with 6,629 additions and 3,740 deletions.
8 changes: 0 additions & 8 deletions .eslintignore

This file was deleted.

293 changes: 0 additions & 293 deletions .eslintrc

This file was deleted.

8 changes: 0 additions & 8 deletions .github/workflows/build-image-reusable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ on:
name:
required: true
type: string
key_for_sentry_secret:
required: false
type: string
key_for_posthog_secret:
required: false
type: string

jobs:
build-container:
Expand Down Expand Up @@ -50,8 +44,6 @@ jobs:

- name: Build image (${{ inputs.name }})
run: |
export SENTRY_KEY=${{ secrets[inputs.key_for_sentry_secret] }}
export POSTHOG_KEY=${{ secrets[inputs.key_for_posthog_secret] }}
./scripts/build_docker.sh build ${{ inputs.name }} ${{ env.SHA }}
- name: Push image
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/build-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,18 @@ on:

jobs:
build-image:
# TODO: remove this, it's only needed for the frontend
strategy:
matrix:
group:
- name: 'staging'
if: true
sentry_key: SENTRY_KEY_staging

- name: 'prod'
if: ${{ github.ref == 'refs/heads/master' }}
sentry_key: SENTRY_KEY_prod
posthog_key: POSTHOG_KEY_prod

# Commented for now
# - name: 'enterprise'
# if: ${{ github.ref == 'refs/heads/master' }}

secrets: inherit
uses: ./.github/workflows/build-image-reusable.yaml
with:
if: ${{ matrix.group.if }}
name: ${{ matrix.group.name }}
key_for_sentry_secret: ${{ matrix.group.sentry_key }}
key_for_posthog_secret: ${{ matrix.group.posthog_key }}
5 changes: 2 additions & 3 deletions .github/workflows/build-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ jobs:
secrets: inherit
with:
package: server
run-cmd: build:staging
run-cmd: build:prod
tags: -t nangohq/nango-server:staging-${{ github.event.pull_request.head.sha || github.sha }}

nango-server-prod:
if: github.ref == 'refs/heads/master'
uses: ./.github/workflows/push-container.yaml
Expand All @@ -49,5 +48,5 @@ jobs:
secrets: inherit
with:
package: server
run-cmd: build:enterprise
run-cmd: build:prod
tags: -t nangohq/nango-server:enterprise -t nangohq/nango-server:enterprise-${{ github.event.pull_request.head.sha || github.sha }}
16 changes: 15 additions & 1 deletion .github/workflows/tests-clients.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,26 @@ on:
merge_group:

jobs:
compute-matrix:
runs-on: ubuntu-latest
outputs:
os-matrix: ${{ steps.set-os-matrix.outputs.os-matrix }}
steps:
- name: Set OS Matrix
id: set-os-matrix
run: |
if [[ '${{ github.ref }}' == 'refs/heads/master' ]]; then
echo "os-matrix=[\"ubuntu-latest\",\"windows-latest\"]" >> $GITHUB_OUTPUT
else
echo "os-matrix=[\"ubuntu-latest\"]" >> $GITHUB_OUTPUT
fi
tests:
needs: compute-matrix
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x, 22.x]
os: [ubuntu-latest, windows-latest]
os: ${{ fromJson(needs.compute-matrix.outputs.os-matrix) }}

runs-on: ${{ matrix.os }}

Expand Down
Loading

0 comments on commit c3582ef

Please sign in to comment.