feat: make connectionId optional when creating a new connection #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Sep 19, 2024
| providerConfigKey: string, | ||
| connectionIdOrConnectionConfig?: string | ConnectionConfig, | ||
| moreConnectionConfig?: ConnectionConfig | ||
| ): Promise<AuthResult> { |
There was a problem hiding this comment.
method overload to allow passing connectionConfig without having to specify an undefined connectionId
TBonnin
commented
Sep 19, 2024
| ? nango.create(target.integration_unique_key.value, target.connection_id.value, connectionConfig) | ||
| : nango.auth(target.integration_unique_key.value, target.connection_id.value, connectionConfig); | ||
|
|
||
| getConnection |
There was a problem hiding this comment.
the compiler doesn't like the dynamic index method calling (I don't know how this is called) with method overloadding. No logic has changed here
There was a problem hiding this comment.
honestly more readable like 👌🏻
bodinsamuel
approved these changes
Sep 20, 2024
| ? nango.create(target.integration_unique_key.value, target.connection_id.value, connectionConfig) | ||
| : nango.auth(target.integration_unique_key.value, target.connection_id.value, connectionConfig); | ||
|
|
||
| getConnection |
There was a problem hiding this comment.
honestly more readable like 👌🏻
| async verify(expectedDigest: string, id: number, ...values: string[]): Promise<boolean> { | ||
| const actualDigest = await this.digest(id, ...values); | ||
| async verify(expectedDigest: string, id: number, ...values: (string | undefined)[]): Promise<boolean> { | ||
| const definedValues: string[] = values.flatMap((v) => (v === undefined ? [] : [v])); |
There was a problem hiding this comment.
filter(Boolean) would not work here?
There was a problem hiding this comment.
you are right, that should work. let me check
There was a problem hiding this comment.
it does work but it will require to cast to string[] because filter doesn't change the type of values. I will leave it like it is then
khaliqgant
approved these changes
Sep 20, 2024
TBonnin
force-pushed
the
tbonnin/nan-1747/optional-connectionid
branch
from
11873d3 to
f88f672
Compare
hassan254-prog
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Describe your changes Making connectionId optional when creating a connection. If connectionId is not provided a uuid is generated. I haven't updated the documentation which is still relevant. I will do it once we decide not passing the connectionId is the default way. With this PR we are making it possible without promoting it yet. ## Issue ticket number and link https://linear.app/nango/issue/NAN-1747/make-connectionid-optional-when-creating-a-new-connection ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: - [ ] I added observability, otherwise the reason is: - [ ] I added analytics, otherwise the reason is:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Making connectionId optional when creating a connection. If connectionId is not provided a uuid is generated.
I haven't updated the documentation which is still relevant. I will do it once we decide not passing the connectionId is the default way. With this PR we are making it possible without promoting it yet.
Issue ticket number and link
https://linear.app/nango/issue/NAN-1747/make-connectionid-optional-when-creating-a-new-connection
Checklist before requesting a review (skip if just adding/editing APIs & templates)