feat(connect-ui): handle generic auth method #2754
Conversation
| }; | ||
|
|
||
| if (this.status === AuthorizationStatus.BUSY) { | ||
| const error = new AuthError('The authorization window is already opened', 'windowIsOppened'); | ||
| const error = new AuthError('The authorization window is already opened', 'windowIsOpened'); |
There was a problem hiding this comment.
fixing this typo might be a breaking change
| reject(error); | ||
| return; |
There was a problem hiding this comment.
we were not rejecting but not returning, not sure if it was intentional but if yes it was annoying to get an error but still get a popup. Happy to discuss
| const creationDateA = a.creationDate || new Date(0); | ||
| const creationDateB = b.creationDate || new Date(0); | ||
| return creationDateB.getTime() - creationDateA.getTime(); | ||
| }) |
There was a problem hiding this comment.
Happy to discuss this sort, I'm sure it was intentional but very confusing to have this "random" sort in the UI
There was a problem hiding this comment.
I imagine it was to show the integrations by most recently added in the dashboard. The sorting can be done client side I think.
There was a problem hiding this comment.
yeah, actually that's what I'm changing because it's super annoying to have seemingly random order in the dashboard.
Maybe @khaliqgant can clarify what were the expectations?
There was a problem hiding this comment.
merging, happy to revert if needed
|
|
||
| this.status = AuthorizationStatus.IDLE; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think that calling clear in nango.auth() will solve this bug: https://linear.app/nango/issue/NAN-1773/fix-the-authorization-window-is-already-opened
| const creationDateA = a.creationDate || new Date(0); | ||
| const creationDateB = b.creationDate || new Date(0); | ||
| return creationDateB.getTime() - creationDateA.getTime(); | ||
| }) |
There was a problem hiding this comment.
I imagine it was to show the integrations by most recently added in the dashboard. The sorting can be done client side I think.
## Describe your changes Contributes to https://linear.app/nango/issue/NAN-1703/create-ui - Handle generic auth method API Key, Basic auth, unauth, and all auth that do not take a connection config (e.g: google drive). If your integration is requiring a connectionConfig it's not yet supported - Frontend: type errors + fix a typo - Frontend: add a way to clear SDK's state, it was annoying to do that manually when debugging - Frontend: slightly change the way the modal is being created We were creating an empty popup and then changing the URL which made the catching of popup blocker more random ## 🧪 Tests ```ts npm i npm run dw npm run dwa cd packages/connect-ui touch .env > VITE_LOCAL_SECRET_KEY=FILL > VITE_LOCAL_PUBLIC_KEY=FILL > VITE_LOCAL_HOSTNAME=http://localhost:3003 npm run connect-ui:dev:watch ``` https://github.com/user-attachments/assets/080d3746-bc1e-457e-a80b-175646fc63a4
Describe your changes
Contributes to https://linear.app/nango/issue/NAN-1703/create-ui
Handle generic auth method
API Key, Basic auth, unauth, and all auth that do not take a connection config (e.g: google drive). If your integration is requiring a connectionConfig it's not yet supported
Frontend: type errors + fix a typo
Frontend: add a way to clear SDK's state, it was annoying to do that manually when debugging
Frontend: slightly change the way the modal is being created
We were creating an empty popup and then changing the URL which made the catching of popup blocker more random
🧪 Tests
Screen.Recording.2024-09-23.at.16.19.41.mov