feat: add GET /connect/session endpoint #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
force-pushed
the
tbonnin/nan-1775/get-connect-session
branch
from
74a3350 to
6fabe59
Compare
bodinsamuel
approved these changes
Sep 27, 2024
| if (session.isErr()) { | ||
| return Err(session.error); | ||
| } | ||
| return Ok(session.value); |
There was a problem hiding this comment.
you can't return session directly?
There was a problem hiding this comment.
I meant this:
Suggested change
| return Ok(session.value); | |
| return session |
instead of the current if err ok
There was a problem hiding this comment.
ok yes. you are right. the unwrapping/wrapping is unnecessary. I will fix next time I touch the code
TBonnin
force-pushed
the
tbonnin/nan-1775/post-connect-sessions
branch
from
d8b2789 to
e96c39b
Compare
TBonnin
force-pushed
the
tbonnin/nan-1775/get-connect-session
branch
2 times, most recently
from
f44b70b to
8d8db83
Compare
TBonnin
force-pushed
the
tbonnin/nan-1775/get-connect-session
branch
from
8d8db83 to
c243733
Compare
TBonnin
force-pushed
the
tbonnin/nan-1775/post-connect-sessions
branch
from
e96c39b to
79808f9
Compare
Base automatically changed from
tbonnin/nan-1775/post-connect-sessions
to
master
September 27, 2024 17:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
depends on #2769
Issue ticket number and link
https://linear.app/nango/issue/NAN-1775/[server]-api-endpoints-to-getpost-sessions