Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept noticing spots where I was getting eslint errors because of our handlers being async but the handler type expected
void
and notPromise<void>
. This updates the type for handlers and cleans up the resulting type errors.If you want to see this in action, before switching to this branch check out line 125 in
packages/jobs/lib/routes/tasks/putTask.ts
. It has an eslint warning because of a misused promise. After this update that eslint warning is gone.