Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use computed matrix for clients tests #3289

Merged
merged 12 commits into from
Jan 10, 2025
Merged

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Jan 10, 2025

Computes a matrix of what os should be tested for client tests, and then runs those:

image

It only runs windows on master, so we still run it after merge, but on PRs just runs on linux, where things are faster. On PRs this cuts time down to 3m10s (on just one run) from a prior runtime of 8m+

@nalanj nalanj self-assigned this Jan 10, 2025
@nalanj nalanj marked this pull request as ready for review January 10, 2025 16:55
@nalanj nalanj requested a review from a team January 10, 2025 16:56
@nalanj nalanj merged commit 466935c into master Jan 10, 2025
19 checks passed
@nalanj nalanj deleted the alan/clients-dynamic-matrix branch January 10, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants