Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: providers package #3308

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

bodinsamuel
Copy link
Collaborator

Changes

Contributes to https://linear.app/nango/issue/NAN-2265/remove-shared-from-cli
Split of #3297

  • New package @nangohq/providers
    Only contains providers.yaml. Compiled and included in tooling but not used in code yet

@bodinsamuel bodinsamuel self-assigned this Jan 15, 2025
Copy link

linear bot commented Jan 15, 2025

@bodinsamuel bodinsamuel marked this pull request as ready for review January 15, 2025 17:22
@bodinsamuel bodinsamuel requested a review from a team January 15, 2025 17:22
@khaliqgant khaliqgant self-requested a review January 15, 2025 18:20
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit comment made inline.

💯 to having it in its own package.

@khaliqgant
Copy link
Member

Can you be sure to ping me when this moves permanently? I have a couple of scripts that are watching the providers.yaml for changes to take some actions on the new provider that was added. Thanks!

@bodinsamuel
Copy link
Collaborator Author

bodinsamuel commented Jan 16, 2025

Can you be sure to ping me when this moves permanently? I have a couple of scripts that are watching the providers.yaml for changes to take some actions on the new provider that was added. Thanks!

Yes probably not before last week of january, until then nothing changes

@bodinsamuel bodinsamuel enabled auto-merge (squash) January 16, 2025 09:40
@bodinsamuel bodinsamuel merged commit f0a409c into master Jan 16, 2025
16 checks passed
@bodinsamuel bodinsamuel deleted the sam/25_01_15/feat/providers-package branch January 16, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants