fix(runner): tweak runner idling retry logic #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the runner keeps notifying `jobs` that it is idle every 10s However 10s might not be enough for jobs/fleet to terminate the runner and following request to /idle fails with an error. This commit increase the timeout when /idle was called successfully to give enough time to jobs/fleet to terminate the runner In theory we could also simply stop the loop once /idle has been successful
nalanj
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really a bug but the runner currently keeps notifying
jobsthat it is idle every 10s.However 10s might not be enough for jobs/fleet to terminate the runner (if we are in the middle of a deploy for example, fleet might need to start/terminate dozen of services and it can take quite a long time). Following requests to /idle then fail with an error since the runner is already considered idled. This commit increase the timeout when /idle was called successfully to give enough time to jobs/fleet to terminate the runner and avoid logging an error.
In theory we could also simply stop the loop once /idle has been successful