Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): Handle null sync_type to stop ui error #3330

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Jan 17, 2025

Came from a customer report. We had a sync_type coming over the API as null, and that caused errors in this condition.

image

@nalanj nalanj self-assigned this Jan 17, 2025
@nalanj nalanj requested a review from a team January 17, 2025 16:59
@nalanj nalanj marked this pull request as ready for review January 17, 2025 16:59
@nalanj nalanj enabled auto-merge (squash) January 17, 2025 17:07
@nalanj
Copy link
Contributor Author

nalanj commented Jan 17, 2025

Went ahead and merged since everyone is out of office right now.

@nalanj
Copy link
Contributor Author

nalanj commented Jan 17, 2025

@bodinsamuel would love your eyes on this regardless of it already being merged to make sure I didn't mess something up

@nalanj nalanj disabled auto-merge January 17, 2025 17:08
@nalanj nalanj merged commit eac32e3 into master Jan 17, 2025
18 checks passed
@nalanj nalanj deleted the alan/ui-null-sync_type branch January 17, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant