fix: use column names for database mappers #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shezadkhan137
force-pushed
the
fix-column-names-for-database-writer
branch
from
d7b5ede to
3cd23fd
Compare
When writing results where the metrics include 'confusion_matrix', only the first column name is written. In the case of the confusion_matrix it is "true_positive". The desired behaviour is to write all column values.
shezadkhan137
force-pushed
the
fix-column-names-for-database-writer
branch
from
3cd23fd to
9acc499
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 82.56% 82.56%
=======================================
Files 100 100
Lines 7552 7553 +1
Branches 1353 1354 +1
=======================================
+ Hits 6235 6236 +1
Misses 980 980
Partials 337 337 ☔ View full report in Codecov by Sentry. |
|
Looking good @shezadkhan137 ! I applied the same solution to the case of CBPE where we had exposed some internal mechanics called components. I don't like those very much, your way of doing it was more elegant. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing results where the metrics include 'confusion_matrix', only the first column name is written. In the case of the confusion_matrix it is "true_positive". The desired behaviour is to write all column values.