Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise variable names in the docs #338

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

santiviquez
Copy link
Contributor

I made the following changes to use the same variable names across all code snippets in the documentation:

reference -> reference_df
analysis -> analysis_df
selected_columns - feature_column_names

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38eaa2a) 82.80% compared to head (6b43c20) 82.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   82.80%   82.68%   -0.12%     
==========================================
  Files         100      100              
  Lines        7554     7544      -10     
  Branches     1357     1168     -189     
==========================================
- Hits         6255     6238      -17     
- Misses        963      969       +6     
- Partials      336      337       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	docs/example_notebooks/Examples California Housing.ipynb
#	docs/example_notebooks/How It Works - Data Reconstruction with PCA.ipynb
#	docs/example_notebooks/How it Works - Ranking.ipynb
#	docs/example_notebooks/Tutorial - Realized Performance - Multiclass Classification.ipynb
#	nannyml/drift/ranker.py
@nnansters nnansters merged commit 51105c7 into NannyML:main Nov 16, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants