Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Statistics submodule #390

Merged
merged 15 commits into from
May 27, 2024
Merged

Refactor Statistics submodule #390

merged 15 commits into from
May 27, 2024

Conversation

nikml
Copy link
Contributor

@nikml nikml commented May 17, 2024

  • Remove copy operations for SizeBasedChunking and use iloc instead of loc
  • Remove copy operations from Base Calculator/Estimator
  • Refactored statistics calculators to more efficiently calculate
  • Added tests to all calculators to ensure reference/analysis data are not changed after using a calculator since we are removing expensive copy operations

@nikml nikml requested a review from nnansters as a code owner May 17, 2024 18:55
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (da33807) to head (cc869eb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   76.52%   76.73%   +0.21%     
==========================================
  Files         110      109       -1     
  Lines        9242     9250       +8     
  Branches     1658     1658              
==========================================
+ Hits         7072     7098      +26     
+ Misses       1703     1686      -17     
+ Partials      467      466       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/stats/test_median.py Outdated Show resolved Hide resolved
tests/stats/test_count.py Outdated Show resolved Hide resolved
tests/stats/test_count.py Outdated Show resolved Hide resolved
tests/stats/test_avg.py Outdated Show resolved Hide resolved
tests/performance_estimation/DLE/test_dle.py Outdated Show resolved Hide resolved
tests/drift/test_drift.py Outdated Show resolved Hide resolved
tests/drift/test_drift.py Outdated Show resolved Hide resolved
tests/drift/test_drift.py Outdated Show resolved Hide resolved
tests/data_quality/test_unseen.py Outdated Show resolved Hide resolved
tests/data_quality/test_missing.py Outdated Show resolved Hide resolved
@nnansters nnansters merged commit 022b8fa into main May 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants