Fixes broken cleanup #2

God-damnit-all · 2022-03-08T07:50:24Z

I noticed that my cookie jar was not saving, leading me to discover this: stil#15

Apparently, the SafeHandles don't actually fire their Cleanup method when being disposed of. I changed it and recompiled and my cookie jar wrote when disposed, so it seems to be fixed.

God-damnit-all · 2022-03-30T17:52:38Z

@NathanielACollier Unrelated to this PR (I tried it without) I'm having a garbage collection issue in PowerShell that I haven't been able to resolve despite having tried many things.

Process terminated. A callback was made on a garbage collected delegate of type 'nac.CurlThin!nac.CurlThin.CurlNative+Easy+DataHandler::Invoke'.
Repeat 2 times:
--------------------------------
   at nac.CurlThin.CurlNative+Easy.Perform(nac.CurlThin.SafeHandles.SafeEasyHandle)
--------------------------------
   at DynamicClass.CallSite.Target(System.Runtime.CompilerServices.Closure, System.Runtime.CompilerServices.CallSite, System.Type, System.Object)
   at System.Dynamic.UpdateDelegates.UpdateAndExecute2[[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.Runtime.CompilerServices.CallSite, System.__Canon, System.__Canon)
   at System.Management.Automation.Interpreter.DynamicInstruction`3[[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.Interpreter.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.LightLambda.RunVoid1[[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.__Canon)
   at System.Management.Automation.PSScriptCmdlet.RunClause(System.Action`1<System.Management.Automation.Language.FunctionContext>, System.Object, System.Object)
   at System.Management.Automation.PSScriptCmdlet.DoProcessRecord()
   at System.Management.Automation.CommandProcessor.ProcessRecord()
   at System.Management.Automation.CommandProcessorBase.DoExecute()
   at System.Management.Automation.Internal.PipelineProcessor.SynchronousExecuteEnumerate(System.Object)
   at System.Management.Automation.PipelineOps.InvokePipeline(System.Object, Boolean, System.Management.Automation.CommandParameterInternal[][], System.Management.Automation.Language.CommandBaseAst[], System.Management.Automation.CommandRedirection[][], System.Management.Automation.Language.FunctionContext)
   at System.Management.Automation.Interpreter.ActionCallInstruction`6[[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Boolean, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.Interpreter.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.LightLambda.RunVoid1[[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.__Canon)
   at System.Management.Automation.DlrScriptCommandProcessor.RunClause(System.Action`1<System.Management.Automation.Language.FunctionContext>, System.Object, System.Object)
   at System.Management.Automation.DlrScriptCommandProcessor.DoProcessRecordWithInput()
   at System.Management.Automation.CommandProcessorBase.DoExecute()
   at System.Management.Automation.Internal.PipelineProcessor.SynchronousExecuteEnumerate(System.Object)
   at System.Management.Automation.PipelineOps.InvokePipeline(System.Object, Boolean, System.Management.Automation.CommandParameterInternal[][], System.Management.Automation.Language.CommandBaseAst[], System.Management.Automation.CommandRedirection[][], System.Management.Automation.Language.FunctionContext)
   at System.Management.Automation.Interpreter.ActionCallInstruction`6[[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Boolean, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.Interpreter.Run(System.Management.Automation.Interpreter.InterpretedFrame)
   at System.Management.Automation.Interpreter.LightLambda.RunVoid1[[System.__Canon, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.__Canon)
   at System.Management.Automation.DlrScriptCommandProcessor.RunClause(System.Action`1<System.Management.Automation.Language.FunctionContext>, System.Object, System.Object)
   at System.Management.Automation.DlrScriptCommandProcessor.Complete()
   at System.Management.Automation.CommandProcessorBase.DoComplete()
   at System.Management.Automation.Internal.PipelineProcessor.DoCompleteCore(System.Management.Automation.CommandProcessorBase)
   at System.Management.Automation.Internal.PipelineProcessor.SynchronousExecuteEnumerate(System.Object)
   at System.Management.Automation.Runspaces.LocalPipeline.InvokeHelper()
   at System.Management.Automation.Runspaces.LocalPipeline.InvokeThreadProc()
   at System.Management.Automation.Runspaces.LocalPipeline.InvokeThreadProcImpersonate()
   at System.Management.Automation.Runspaces.PipelineThread.WorkerProc()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
Exit code: -2146232797

Any idea on how to handle this?

NathanielACollier · 2022-03-30T18:10:17Z

Would you be able to provide powershell code? I can't promise I'd be able to figure it out, but I'm really interested to see powershell code that invokes this library.

God-damnit-all · 2022-03-30T18:20:36Z

Would you be able to provide powershell code? I can't promise I'd be able to figure it out, but I'm really interested to see powershell code that invokes this library.

Added you to the repo. Note that it will have to be modified if you don't want to use the preview release of PowerShell.

Usually the way I get the GC problem to trigger the fastest is a 20-count loop against https://qwant.com

puyebu · 2022-03-31T16:35:25Z

I am experiencing the same GC error.
I assume it happens due to memory leak fix because I can replicate the issue on stil/CurlThin by doing the same changes.
Basically, with base(IntPtr.Zero, false) I experience memory leak while with base(IntPtr.Zero, true) I experience GC error.

God-damnit-all · 2022-03-31T17:08:53Z

I am experiencing the same GC error. I assume it happens due to memory leak fix because I can replicate the issue on stil/CurlThin by doing the same changes. Basically, with base(IntPtr.Zero, false) I experience memory leak while with base(IntPtr.Zero, true) I experience GC error.

I think you misspoke? Having it be false should be causing a memory leak, though it can actually experience the same GC issue.

puyebu · 2022-03-31T19:53:22Z

I am experiencing the same GC error. I assume it happens due to memory leak fix because I can replicate the issue on stil/CurlThin by doing the same changes. Basically, with base(IntPtr.Zero, false) I experience memory leak while with base(IntPtr.Zero, true) I experience GC error.

I think you misspoke? Having it be false should be causing a memory leak, though it can actually experience the same GC issue.

I may have been unclear.
With false I get the memory leak, with true I get GC error.

Should be noted that I did not get GC error with debugger attached (in debug build) on 4000 loops, I do get GC error after 20-30 loops on release build without debugger.

God-damnit-all · 2022-04-01T03:45:19Z

I may have been unclear. With false I get the memory leak, with true I get GC error.

Should be noted that I did not get GC error with debugger attached (in debug build) on 4000 loops, I do get GC error after 20-30 loops on release build without debugger.

The debugger changes how the call stack is handled, so that's not surprising.

deathasaku · 2023-05-16T13:41:26Z

because when GC triggers safeslisthandle.releasehandle
CurlNative.Slist.FreeAll(this) trigger DangerousAddref，then throw error

Fixes broken cleanup

62abd56

NathanielACollier merged commit 631f9cf into NathanielACollier:master Mar 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes broken cleanup #2

Fixes broken cleanup #2

God-damnit-all commented Mar 8, 2022

God-damnit-all commented Mar 30, 2022

NathanielACollier commented Mar 30, 2022

God-damnit-all commented Mar 30, 2022 •

edited

Loading

puyebu commented Mar 31, 2022 •

edited

Loading

God-damnit-all commented Mar 31, 2022

puyebu commented Mar 31, 2022 •

edited

Loading

God-damnit-all commented Apr 1, 2022

deathasaku commented May 16, 2023

Fixes broken cleanup #2

Fixes broken cleanup #2

Conversation

God-damnit-all commented Mar 8, 2022

God-damnit-all commented Mar 30, 2022

NathanielACollier commented Mar 30, 2022

God-damnit-all commented Mar 30, 2022 • edited Loading

puyebu commented Mar 31, 2022 • edited Loading

God-damnit-all commented Mar 31, 2022

puyebu commented Mar 31, 2022 • edited Loading

God-damnit-all commented Apr 1, 2022

deathasaku commented May 16, 2023

God-damnit-all commented Mar 30, 2022 •

edited

Loading

puyebu commented Mar 31, 2022 •

edited

Loading

puyebu commented Mar 31, 2022 •

edited

Loading