Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NKS): Add nodepool label & taints #394

Merged
merged 10 commits into from
Dec 19, 2023
Merged

feat(NKS): Add nodepool label & taints #394

merged 10 commits into from
Dec 19, 2023

Conversation

gimmetm
Copy link
Collaborator

@gimmetm gimmetm commented Dec 11, 2023

  • resource_ncloud_nks_cluster
    • add hypervisor_code
    • lb_private_subnet_no, lb_public_subnet_no change support
    • add ip_acl_default_action validtaion : error on fin site
  • datasource_ncloud_nks_cluster
    • add hypervisor_code
  • resource_ncloud_nks_nodepool
    • subnet_no_list change support(only add)
    • add label
    • add taints
  • datasource_ncloud_nks_nodepool
    • add label
    • add taints
  • datasource_ncloud_nks_server_images
    • add hypervisor_code
  • datasource_ncloud_nks_server_products
    • fix filter
    • variable depth changed

youngmn
youngmn reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@youngmn youngmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint 에러가 발생하고 있는데, 확인 부탁드립니다.

internal/service/nks/nks_cluster_data_source_test.go Show resolved Hide resolved
docs/data-sources/nks_node_pool.md Outdated Show resolved Hide resolved
docs/resources/nks_cluster.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
internal/service/nks/nks_node_pools_data_source_test.go Show resolved Hide resolved
internal/service/nks/nks_node_pool_data_source_test.go Show resolved Hide resolved
internal/service/nks/nks_kube_config_data_source_test.go Show resolved Hide resolved
@wonchulee wonchulee force-pushed the feature/nks-label-taints branch from b5e4d5c to ed1f0ba Compare December 16, 2023 04:02
@wonchulee wonchulee changed the title update: nks nodepool label & taints feat(NKS): Add nodepool label & taints Dec 19, 2023
mingyum-kim-n and others added 8 commits December 19, 2023 18:32
@mingyum-kim-n @wonchulee
update: nks nodepool label & taints
ab76b96
@mingyum-kim-n @wonchulee
fix: nks example typo
f08825b
@mingyum-kim-n @wonchulee
update:
8fde53b 
- remove replace in go.mod
- add subcategory to nks_cluster docs
- rollback datasource.nks_node_pool Argument Reference
- datasource.ncloud_nks_server_products details deprecated
@mingyum-kim-n @wonchulee
fix: lint
83391a4
@wonchulee
fix: Skip Acceptance tests when TF_ACC env is unset
7f8759a
@mingyum-kim-n @wonchulee
remove: NKS KVM Acc test cases
58f026f
@wonchulee
chore(nks): Update example
445590d
@wonchulee
chore(nks): Update test url
0946eff
@wonchulee wonchulee force-pushed the feature/nks-label-taints branch from 5421b14 to a047b60 Compare December 19, 2023 09:39
@wonchulee wonchulee force-pushed the feature/nks-label-taints branch from a047b60 to cccffa1 Compare December 19, 2023 09:43
@wonchulee wonchulee force-pushed the feature/nks-label-taints branch from b7ff34c to bebe764 Compare December 19, 2023 12:26
@wonchulee wonchulee merged commit a5a12bb into NaverCloudPlatform:main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngmn youngmn youngmn left review comments

@wonchulee wonchulee wonchulee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gimmetm @wonchulee @youngmn @mingyum-kim-n