Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hadoop): Update Hadoop image products Data Source #411

Merged
merged 1 commit into from
Feb 7, 2024
Merged

refactor(hadoop): Update Hadoop image products Data Source #411

merged 1 commit into from
Feb 7, 2024

Conversation

youngmn
Copy link
Collaborator

@youngmn youngmn commented Feb 6, 2024

Related

#390

Description

  • Update Data-Source : ncloud_hadoop_images -> ncloud_hadoop_image_products
  • Change
    • LOG format
    • ERROR format
    • Refacoring Schema
    • Update DOCS

AccTest results

=== RUN   TestAccDataSourceNcloudHadoopImages_basic
--- PASS: TestAccDataSourceNcloudHadoopImages_basic (2.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ncloud/internal/service/hadoop	2.997s

@youngmn youngmn requested a review from wonchulee as a code owner February 6, 2024 09:54
wonchulee
wonchulee approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youngmn youngmn merged commit ff35316 into main Feb 7, 2024
4 checks passed
@youngmn youngmn deleted the refact/hadoop_image branch February 7, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonchulee wonchulee wonchulee approved these changes

Assignees
No one assigned
Labels
documentation enhancement FRAMEWORK VPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngmn @wonchulee