Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(postgresql): Update PostgreSQL Resource and Data Source #483

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

youngmn
Copy link
Collaborator

@youngmn youngmn commented Nov 22, 2024

Related

#452
#480

Description

  • Resource : ncloud_postgresql, ncloud_postgresql_users, ncloud_postgresql_databases, ncloud_postgresql_read_replica
  • Data-Source : ncloud_postgresql, ncloud_postgresql_users, ncloud_postgresql_databases
  • All Refactoring

AccTest results

=== RUN   TestAccResourceNcloudPostgresql_vpc_basic
--- PASS: TestAccResourceNcloudPostgresql_vpc_basic (766.33s)
=== RUN   TestAccResourceNcloudPostgresql_vpc_multizone
--- PASS: TestAccResourceNcloudPostgresql_vpc_multizone (743.57s)
=== RUN   TestAccResourceNcloudPostgresql_vpc_error
--- PASS: TestAccResourceNcloudPostgresql_vpc_error (49.06s)
=== RUN   TestAccDataSourceNcloudPostgresql_vpc_basic
--- PASS: TestAccDataSourceNcloudPostgresql_vpc_basic (754.41s)
=== RUN   TestAccDataSourceNcloudPostgresqlUsers_vpc_basic
--- PASS: TestAccDataSourceNcloudPostgresqlUsers_vpc_basic (770.50s)
=== RUN   TestAccResourceNcloudPostgresqlUsers_vpc_basic
--- PASS: TestAccResourceNcloudPostgresqlUsers_vpc_basic (830.69s)
=== RUN   TestAccResourceNcloudPostgresqlDatabases_vpc_basic
--- PASS: TestAccResourceNcloudPostgresqlDatabases_vpc_basic (709.73s)
=== RUN   TestAccDataSourceNcloudPostgresqlDatabases_vpc_basic
--- PASS: TestAccDataSourceNcloudPostgresqlDatabases_vpc_basic (744.03s)
=== RUN   TestAccResourceNcloudPostgresqlReadReplica_vpc_basic
--- PASS: TestAccResourceNcloudPostgresqlReadReplica_vpc_basic (1211.82s)
PASS


@youngmn youngmn requested a review from wonchulee as a code owner November 22, 2024 01:47
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM 👍 (needs to discuss the way of multiple users import though)

docs/resources/postgresql_read_replica.md Outdated Show resolved Hide resolved
@youngmn youngmn merged commit d58cec1 into main Jan 3, 2025
4 checks passed
@youngmn youngmn deleted the refact/postgresql branch January 3, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants