Handle Klat persona update events #10
Draft
+558
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonDaniel
commented
Dec 11, 2024
Adds docstrings and type annotations to persona-related modules Adds handler for `<name>_personas_input` queue to manage updates from Klat Modifies default behavior to not periodically sync with the database (all relevant changes will be handled individually)
…recent update is always applied
…nd new events for persona update
NeonKirill
force-pushed
the
FEAT_PersonaUpdateEvents
branch
from
a0be34c to
d412032
Compare
Streamline persona update and removal logic by introducing better handling for default personas, improved logging messages, and replacing unnecessary delays with helper methods. Removed redundant code to enhance readability and maintain consistency across the persona management workflow.
…ersState functionalities. - Added a mock PersonaFactory for easier persona generation in tests. - Improved persona validation and handling, ensuring proper setup and teardown of default and incoming personas.
NeonDaniel
commented
Jan 28, 2025
There was a problem hiding this comment.
Left some initial feedback; I can manually build some containers to test this after NeonGeckoCom/pyklatchat#107 is merged/deployed to alpha
| @@ -0,0 +1,20 @@ | |||
| import uuid | |||
There was a problem hiding this comment.
New file needs license notice (also __init__.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds docstrings and type annotations to persona-related modules
Adds handler for
<name>_personas_inputqueue to manage updates from KlatModifies default behavior to not periodically sync with the database (all relevant changes will be handled individually)
Issues
Closes #8
Implements NeonGeckoCom/pyklatchat#107
Other Notes
This does not currently account for multiple concurrent updates. One possible solution is to include a timestamp with emitted changes and discard any messages containing changes that are older than what was most recently applied.