Add static and runtime dag info, API to fetch ancestor and successor tasks #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talsperre
force-pushed
the
dev/add-runtime-dag-info
branch
from
48c771d to
ec43f14
Compare
saikonen
reviewed
Nov 11, 2024
metaflow/metadata/metadata.py
Outdated
Comment on lines
675
to
690
| @classmethod | ||
| def _filter_tasks_by_metadata( | ||
| cls, flow_id, run_id, query_step, field_name, field_value | ||
| ): | ||
| raise NotImplementedError() | ||
|
|
||
| @classmethod | ||
| def filter_tasks_by_metadata( | ||
| cls, flow_id, run_id, query_step, field_name, field_value | ||
| ): | ||
| # TODO: Do we need to do anything wrt to task attempt? | ||
| task_ids = cls._filter_tasks_by_metadata( | ||
| flow_id, run_id, query_step, field_name, field_value | ||
| ) | ||
| return task_ids | ||
|
|
There was a problem hiding this comment.
is there a need for the private method, or could this simply be contained in the public-facing one? right now its not doing anything before calling the private one.
There was a problem hiding this comment.
also, did you have an implementation of this for service.py yet?
metaflow/metadata/metadata.py
Outdated
| def filter_tasks_by_metadata( | ||
| cls, flow_id, run_id, query_step, field_name, field_value | ||
| ): | ||
| # TODO: Do we need to do anything wrt to task attempt? |
There was a problem hiding this comment.
probably not, as the ancestors for task attempts should be identical, right? What about the immediate_siblings though, will they include or exclude attempts of the same task?
talsperre
force-pushed
the
dev/add-runtime-dag-info
branch
from
ffbf68a to
c6fb9ac
Compare
talsperre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add runtime DAG info so that we can query the ancestor and successor tasks for a given task easily.
Usage
To get ancestors, progenies, and siblings, use the following API: