Skip to content

Commit

Permalink
Skip tests BlockWithReceipts due to invalid test asserts (#2374)
Browse files Browse the repository at this point in the history
The test expects transaction_hash in the transaction object, but according to the spec, it's only required under receipt.
  • Loading branch information
wojciechos authored Jan 14, 2025
1 parent 0239e77 commit 27b6968
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/starknet-go-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,6 @@ jobs:
run: go mod download

- name: Test RPC on testnet
run: cd rpc && go test -timeout 1200s -v -env testnet .
run: cd rpc && go test -skip 'TestBlockWithReceipts' -timeout 1200s -v -env testnet .
env:
INTEGRATION_BASE: ${{ secrets.TEST_RPC_URL }}
2 changes: 1 addition & 1 deletion .github/workflows/starknet-rs-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Run jsonrpc tests
run: |
cd starknet-providers && cargo test jsonrpc
cd ../starknet-accounts && cargo test jsonrpc -- --skip can_declare_cairo0_contract_with_jsonrpc
cd ../starknet-accounts && cargo test jsonrpc -- --skip can_declare_cairo0_contract_with_jsonrpc --skip jsonrpc_get_block_with_receipts
env:
STARKNET_RPC: ${{ secrets.STARKNET_RPC }}
RUST_BACKTRACE: full

0 comments on commit 27b6968

Please sign in to comment.