Fix trace pending txns

Co-authored-by: IronGauntlets <aneeque@nethermind.io>
NethermindEth · Jan 17, 2025 · fe1040c · fe1040c
1 parent 0c9ee5a
commit fe1040c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/rpc/trace.go b/rpc/trace.go
@@ -11,6 +11,7 @@ import (
 	"github.com/NethermindEth/juno/blockchain"
 	"github.com/NethermindEth/juno/core"
 	"github.com/NethermindEth/juno/core/felt"
+	"github.com/NethermindEth/juno/db"
 	"github.com/NethermindEth/juno/jsonrpc"
 	"github.com/NethermindEth/juno/starknet"
 	"github.com/NethermindEth/juno/sync"
@@ -141,7 +142,7 @@ func (h *Handler) traceTransaction(ctx context.Context, hash *felt.Felt) (*vm.Tr
 	httpHeader := http.Header{}
 	httpHeader.Set(ExecutionStepsHeader, "0")
 
-	if err != nil {
+	if err != nil && !errors.Is(err, db.ErrKeyNotFound) {
 		return nil, httpHeader, ErrTxnHashNotFound
 	}
 

diff --git a/rpc/trace_test.go b/rpc/trace_test.go
@@ -89,6 +89,7 @@ func TestTraceTransaction(t *testing.T) {
 		hash := utils.HexToFelt(t, "0xBBBB")
 		// Receipt() returns error related to db
 		mockReader.EXPECT().Receipt(hash).Return(nil, nil, uint64(0), db.ErrKeyNotFound)
+		mockSyncReader.EXPECT().Pending().Return(&sync.Pending{Block: &core.Block{}}, nil)
 
 		trace, httpHeader, err := handler.TraceTransaction(context.Background(), *hash)
 		assert.Nil(t, trace)