Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC v0.6-rc1 #1427

Merged
merged 6 commits into from
Nov 27, 2023
Merged

RPC v0.6-rc1 #1427

merged 6 commits into from
Nov 27, 2023

Conversation

joshklop
Copy link
Contributor

No description provided.

@joshklop joshklop force-pushed the joshklop/rpc-v0.6-rc1 branch from 1f97e39 to dfee656 Compare November 14, 2023 20:43
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (4e4af10) 72.46% compared to head (e2d7880) 72.72%.

Files Patch % Lines
rpc/handlers.go 80.15% 23 Missing and 3 partials ⚠️
rpc/transaction.go 82.19% 12 Missing and 1 partial ⚠️
rpc/trace.go 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
+ Coverage   72.46%   72.72%   +0.26%     
==========================================
  Files          93       93              
  Lines        9594     9726     +132     
==========================================
+ Hits         6952     7073     +121     
- Misses       2114     2121       +7     
- Partials      528      532       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshklop joshklop force-pushed the joshklop/rpc-v0.6-rc1 branch 8 times, most recently from 387c2e1 to 9934285 Compare November 15, 2023 21:54
core/transaction.go Outdated Show resolved Hide resolved
vm/rust/src/jsonrpc.rs Outdated Show resolved Hide resolved
rpc/trace.go Outdated Show resolved Hide resolved
rpc/handlers.go Outdated Show resolved Hide resolved
@joshklop joshklop marked this pull request as ready for review November 16, 2023 12:20
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
starknet/transaction.go Outdated Show resolved Hide resolved
vm/rust/src/lib.rs Outdated Show resolved Hide resolved
@joshklop joshklop force-pushed the joshklop/rpc-v0.6-rc1 branch 8 times, most recently from 8099890 to 6153f4e Compare November 17, 2023 03:02
starknet/block.go Outdated Show resolved Hide resolved
@joshklop joshklop force-pushed the joshklop/rpc-v0.6-rc1 branch from 5db77ad to 0441098 Compare November 23, 2023 22:54
@joshklop joshklop requested a review from omerfirmak November 24, 2023 01:43
@omerfirmak omerfirmak force-pushed the joshklop/rpc-v0.6-rc1 branch from 37e1141 to 923ecbd Compare November 24, 2023 07:24
@joshklop joshklop force-pushed the joshklop/rpc-v0.6-rc1 branch from 923ecbd to 56b07e1 Compare November 24, 2023 11:27
@omerfirmak omerfirmak force-pushed the joshklop/rpc-v0.6-rc1 branch from 56b07e1 to e9ea3b5 Compare November 27, 2023 10:42
Copy link
Contributor

@omerfirmak omerfirmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash merging, but please take a look at the latest commits that I added @joshklop

@omerfirmak omerfirmak force-pushed the joshklop/rpc-v0.6-rc1 branch from e9ea3b5 to 8b04df7 Compare November 27, 2023 10:46
@omerfirmak omerfirmak force-pushed the joshklop/rpc-v0.6-rc1 branch from 8b04df7 to 5ed3fd8 Compare November 27, 2023 10:59
@omerfirmak omerfirmak merged commit dd66ec4 into main Nov 27, 2023
9 of 10 checks passed
@omerfirmak omerfirmak deleted the joshklop/rpc-v0.6-rc1 branch November 27, 2023 11:51
sarabrajsingh pushed a commit to sarabrajsingh/juno that referenced this pull request Nov 27, 2023
while also removing support for the legacy v0.4

Co-authored-by: Ömer Faruk IRMAK <omerfirmak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starknet 0.13.0 readiness - Blockifier update Starknet 0.13.0 readiness - Transactions V3 support
3 participants