Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trace to CLI help output #1868

Merged
merged 2 commits into from
May 17, 2024
Merged

add trace to CLI help output #1868

merged 2 commits into from
May 17, 2024

Conversation

LordGhostX
Copy link
Contributor

This PR is a follow-up to #1822 and fully resolves #1767

  • Added trace option to the log-level description in the CLI
  • Resolve casing issues (websocket -> WebSocket, GRPC -> gRPC, yaml -> YAML, prometheus -> Prometheus)
  • Fix typo in CLI description

@LordGhostX LordGhostX added Documentation Improvements or additions to documentation CLI Command line interface go Pull requests that update Go code labels May 16, 2024
@LordGhostX LordGhostX requested a review from wojciechos May 16, 2024 15:56
@LordGhostX LordGhostX self-assigned this May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (3283b79) to head (87a0f29).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1868      +/-   ##
==========================================
+ Coverage   75.32%   75.42%   +0.09%     
==========================================
  Files          97       97              
  Lines        8333     8333              
==========================================
+ Hits         6277     6285       +8     
+ Misses       1521     1517       -4     
+ Partials      535      531       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos wojciechos added this to the v0.12.0 milestone May 16, 2024
cmd/juno/juno.go Outdated Show resolved Hide resolved
@LordGhostX LordGhostX merged commit 1ae9019 into main May 17, 2024
10 checks passed
@LordGhostX LordGhostX deleted the add-trace-to-cli branch May 17, 2024 09:04
@stranger80 stranger80 modified the milestones: v0.12.0, v0.11.8 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Command line interface Documentation Improvements or additions to documentation go Pull requests that update Go code
Projects
Status: Ready For Release
Development

Successfully merging this pull request may close these issues.

Add trace option to --log-level for In-Depth RPC Logging
3 participants