Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slices, for loop copy, min/max update #2006

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

AnkushinDaniil
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil commented Jul 31, 2024

  • Integrate slices pkg, min/max functions
  • For loops update from
    for item := something {
        copyItem := item
        /* use of copyItem */
    }
    to
    for item := something {
        /* use of copyItem */ 
    }
  • Optimise memory allocations

core/transaction.go Outdated Show resolved Hide resolved
rpc/events_test.go Outdated Show resolved Hide resolved
@AnkushinDaniil AnkushinDaniil requested a review from kirugan July 31, 2024 15:58
@AnkushinDaniil AnkushinDaniil deleted the branch NethermindEth:main August 1, 2024 11:56
@AnkushinDaniil AnkushinDaniil deleted the main branch August 1, 2024 11:56
@AnkushinDaniil AnkushinDaniil restored the main branch August 1, 2024 13:31
@AnkushinDaniil AnkushinDaniil reopened this Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (63701db) to head (fae2c27).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
+ Coverage   75.42%   75.47%   +0.04%     
==========================================
  Files         100      100              
  Lines        8990     8982       -8     
==========================================
- Hits         6781     6779       -2     
+ Misses       1605     1601       -4     
+ Partials      604      602       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/state.go Outdated Show resolved Hide resolved
core/transaction.go Outdated Show resolved Hide resolved
@AnkushinDaniil AnkushinDaniil deleted the branch NethermindEth:main August 5, 2024 09:29
@AnkushinDaniil AnkushinDaniil deleted the main branch August 5, 2024 09:29
@AnkushinDaniil AnkushinDaniil restored the main branch August 5, 2024 09:29
@AnkushinDaniil AnkushinDaniil reopened this Aug 5, 2024
@AnkushinDaniil AnkushinDaniil merged commit a30d388 into NethermindEth:main Aug 5, 2024
17 checks passed
@AnkushinDaniil AnkushinDaniil deleted the main branch August 5, 2024 11:43
AnkushinDaniil added a commit that referenced this pull request Aug 12, 2024
* Update slices, for loop copy, min/max functions

* Revert append update

* Fix typo

* Fix linter

* Resolve merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants