Increase default db-cache-size to 1GiB #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiihann
approved these changes
Oct 28, 2024
wojciechos
force-pushed
the
wojciechos/default-db-cache
branch
from
2e3c2ad to
5ca4a8c
Compare
wojciechos
force-pushed
the
wojciechos/default-db-cache
branch
from
5ca4a8c to
aea2165
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
- Coverage 75.63% 75.60% -0.03%
==========================================
Files 104 104
Lines 11102 11102
==========================================
- Hits 8397 8394 -3
- Misses 2073 2075 +2
- Partials 632 633 +1 ☔ View full report in Codecov by Sentry. |
derrix060
approved these changes
Oct 28, 2024
kirugan
approved these changes
Oct 28, 2024
pnowosie
pushed a commit
that referenced
this pull request
Nov 5, 2024
pnowosie
pushed a commit
that referenced
this pull request
Nov 5, 2024
wojciechos
added a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased the default db-cache-size from 8MB to 1GiB to improve sync performance. Profiling showed high CPU usage and frequent DB access during block sync, particularly with larger blocks. This cache increase helps reduce I/O overhead and speeds up access to stored data, resulting in better performance for syncing nodes.