L1 migration #2259
Closed
L1 migration #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix hash function and tests lint lint
Co-authored-by: Aneeque <aneequesafdar@gmail.com> Signed-off-by: Rian Hughes <ryanhughes4500@hotmail.com>
The user chooses not to provide eth node therefore they are expected to understand the consequences. Also, there is already an error message is someone tries to request `starknet_getMessageStatus` without providing an eth-node.
Since it is only used in one place there is no need to have a variable for it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
==========================================
- Coverage 75.40% 75.25% -0.16%
==========================================
Files 106 107 +1
Lines 11237 11443 +206
==========================================
+ Hits 8473 8611 +138
- Misses 2128 2179 +51
- Partials 636 653 +17 ☔ View full report in Codecov by Sentry. |
|
This PR was an idea how we can improve L1 migration, but unfortunately speed up wasn't significant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.