Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos fix #2329

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 0 additions & 150 deletions CODE_OF_CONDUCT.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a mistake here, you have removed a whole CODE_OF_CONDUCT.md

Copy link
Author

@romashka-btc romashka-btc Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a mistake here, you have removed a whole CODE_OF_CONDUCT.md

hmmm, and what you reccomend to do now ? @AnkushinDaniil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c
Try reverting to this commit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c Try reverting to this commit

ok, i will do it in 5-8 hours, pls do not close it, because i need go to work now. @AnkushinDaniil thank you !

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c Try reverting to this commit

i can not reverting it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be correct 368fb7c Try reverting to this commit

maybe you will add only another changes ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry, but I can't. Why not have a go at finding out how to do that yourself? I'm sure you'd be able to manage it, it's not that difficult.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry, but I can't. Why not have a go at finding out how to do that yourself? I'm sure you'd be able to manage it, it's not that difficult.

i do not understaand what i need to do. can you help me?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All you need to do to get things back to where they should be is either revert the last commit or add one more commit that reverts your last change

This file was deleted.

2 changes: 1 addition & 1 deletion core/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ func (s *State) updateContractStorages(stateTrie *trie.Trie, diffs map[felt.Felt
}
}

// sort the contracts in decending diff size order
// sort the contracts in descending diff size order
// so we start with the heaviest update first
keys := slices.SortedStableFunc(maps.Keys(diffs), func(a, b felt.Felt) int { return len(diffs[a]) - len(diffs[b]) })

Expand Down
2 changes: 1 addition & 1 deletion db/db.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ func discardTxnOnPanic(txn Transaction) {
p := recover()
if p != nil {
if err := txn.Discard(); err != nil {
fmt.Fprintf(os.Stderr, "failed discarding panicing txn err: %s", err)
fmt.Fprintf(os.Stderr, "failed discarding panicking txn err: %s", err)
}
panic(p)
}
Expand Down