Miscellaneous changes

clients/feeder/feeder.go

@@ -92,7 +92,7 @@ func NopBackoff(d time.Duration) time.Duration {
 }
 
 // NewTestClient returns a client and a function to close a test server.
-func NewTestClient(t *testing.T, network *utils.Network) *Client {
+func NewTestClient(t testing.TB, network *utils.Network) *Client {
 	srv := newTestServer(t, network)
 	t.Cleanup(srv.Close)
 	ua := "Juno/v0.0.1-test Starknet Implementation"
@@ -117,7 +117,7 @@ func NewTestClient(t *testing.T, network *utils.Network) *Client {
 	return c
 }
 
-func newTestServer(t *testing.T, network *utils.Network) *httptest.Server {
+func newTestServer(t testing.TB, network *utils.Network) *httptest.Server {
 	return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		queryMap, err := url.ParseQuery(r.URL.RawQuery)
 		if err != nil {

core/crypto/pedersen_hash.go

@@ -19,7 +19,8 @@ func PedersenArray(elems ...*felt.Felt) *felt.Felt {
 // [Pedersen hash]: https://docs.starknet.io/architecture-and-concepts/cryptography/hash-functions/#pedersen_hash
 func Pedersen(a, b *felt.Felt) *felt.Felt {
 	hash := pedersenhash.Pedersen(a.Impl(), b.Impl())
-	return felt.NewFelt(&hash)
+	f := felt.New(hash)
+	return &f
 }
 
 var _ Digest = (*PedersenDigest)(nil)
@@ -39,5 +40,6 @@ func (d *PedersenDigest) Update(elems ...*felt.Felt) Digest {
 
 func (d *PedersenDigest) Finish() *felt.Felt {
 	d.digest = pedersenhash.Pedersen(&d.digest, new(fp.Element).SetUint64(d.count))
-	return felt.NewFelt(&d.digest)
+	f := felt.New(d.digest)
+	return &f
 }

core/crypto/poseidon_hash.go

@@ -113,7 +113,7 @@ func setRoundKeys() {
 	}
 }
 
-var _ Digest = (*PedersenDigest)(nil)
+var _ Digest = (*PoseidonDigest)(nil)
 
 type PoseidonDigest struct {
 	state    [3]felt.Felt

core/felt/felt.go

@@ -14,9 +14,9 @@ type Felt struct {
 	val fp.Element
 }
 
-func NewFelt(element *fp.Element) *Felt {
-	return &Felt{
-		val: *element,
+func New(element fp.Element) Felt {
+	return Felt{
+		val: element,
 	}
 }
 

core/state_update_test.go

@@ -79,6 +79,18 @@ func TestStateDiffHash(t *testing.T) {
 	}
 }
 
+func BenchmarkStateDiffHash(b *testing.B) {
+	client := feeder.NewTestClient(b, &utils.SepoliaIntegration)
+	gw := adaptfeeder.New(client)
+	su, err := gw.StateUpdate(context.Background(), 38748)
+	require.NoError(b, err)
+
+	b.ResetTimer()
+	for n := 0; n < b.N; n++ {
+		su.StateDiff.Hash()
+	}
+}
+
 func TestStateDiffLength(t *testing.T) {
 	client := feeder.NewTestClient(t, &utils.Sepolia)
 	gw := adaptfeeder.New(client)