Adds TODO comments and set a pointer to Marshal method

NethermindEth · Nov 8, 2024 · 0d21cbd · 0d21cbd
1 parent b7ce944
commit 0d21cbd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/rpc/call_test.go b/rpc/call_test.go
@@ -108,6 +108,7 @@ func TestCall(t *testing.T) {
 	}[testEnv]
 
 	for _, test := range testSet {
+		// TODO: create a test case for the new 'CONTRACT_EXECUTION_ERROR' type"
 		require := require.New(t)
 		output, err := testConfig.provider.Call(context.Background(), FunctionCall(test.FunctionCall), test.BlockID)
 		if test.ExpectedError != nil {

diff --git a/rpc/contract_test.go b/rpc/contract_test.go
@@ -482,6 +482,7 @@ func TestEstimateMessageFee(t *testing.T) {
 
 func TestEstimateFee(t *testing.T) {
 	//TODO: upgrade the mainnet and testnet test cases before merge
+	//TODO: create a test case for the new 'CONTRACT_EXECUTION_ERROR' type
 
 	testConfig := beforeEach(t)
 

diff --git a/rpc/errors.go b/rpc/errors.go
@@ -117,7 +117,7 @@ func (rpcData *RPCData) UnmarshalJSON(data []byte) error {
 	return fmt.Errorf("failed to unmarshal RPCData")
 }
 
-func (rpcData RPCData) MarshalJSON() ([]byte, error) {
+func (rpcData *RPCData) MarshalJSON() ([]byte, error) {
 	var temp any
 
 	if rpcData.ContractErrorData != nil {