fix: typed message with wrong domain name (#417)

Co-authored-by: Carmen Irene Cabrera Rodríguez <49727740+cicr99@users.noreply.github.com>
NethermindEth · Oct 20, 2023 · 13df8a0 · 13df8a0
1 parent 364beae
commit 13df8a0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/typed/typed.go b/typed/typed.go
@@ -105,11 +105,11 @@ func NewTypedData(types map[string]TypeDef, pType string, dom Domain) (td TypedD
 	return td, nil
 }
 
-// (ref: https://github.com/0xs34n/starknet.js/blob/767021a203ac0b9cdb282eb6d63b33bfd7614858/src/utils/typedData/index.ts#L166)
+// (ref: https://github.com/starknet-io/starknet.js/blob/d7bfc37ede85448e0a55ee4efe65200ff2c45f91/src/utils/typedData.ts#L249)
 func (td TypedData) GetMessageHash(account *big.Int, msg TypedMessage, sc curve.StarkCurve) (hash *big.Int, err error) {
-	elements := []*big.Int{utils.UTF8StrToBig("Starknet Message")}
+	elements := []*big.Int{utils.UTF8StrToBig("StarkNet Message")}
 
-	domEnc, err := td.GetTypedMessageHash("StarknetDomain", td.Domain, sc)
+	domEnc, err := td.GetTypedMessageHash("StarkNetDomain", td.Domain, sc)
 	if err != nil {
 		return hash, fmt.Errorf("could not hash domain: %w", err)
 	}

diff --git a/typed/typed_test.go b/typed/typed_test.go
@@ -36,14 +36,14 @@ func (mail Mail) FmtDefinitionEncoding(field string) (fmtEnc []*big.Int) {
 func MockTypedData() (ttd TypedData) {
 	exampleTypes := make(map[string]TypeDef)
 	domDefs := []Definition{{"name", "felt"}, {"version", "felt"}, {"chainId", "felt"}}
-	exampleTypes["StarknetDomain"] = TypeDef{Definitions: domDefs}
+	exampleTypes["StarkNetDomain"] = TypeDef{Definitions: domDefs}
 	mailDefs := []Definition{{"from", "Person"}, {"to", "Person"}, {"contents", "felt"}}
 	exampleTypes["Mail"] = TypeDef{Definitions: mailDefs}
 	persDefs := []Definition{{"name", "felt"}, {"wallet", "felt"}}
 	exampleTypes["Person"] = TypeDef{Definitions: persDefs}
 
 	dm := Domain{
-		Name:    "Starknet Mail",
+		Name:    "StarkNet Mail",
 		Version: "1",
 		ChainId: "1",
 	}
@@ -101,7 +101,7 @@ func BenchmarkGetMessageHash(b *testing.B) {
 func TestGeneral_GetDomainHash(t *testing.T) {
 	ttd := MockTypedData()
 
-	hash, err := ttd.GetTypedMessageHash("StarknetDomain", ttd.Domain, curve.Curve)
+	hash, err := ttd.GetTypedMessageHash("StarkNetDomain", ttd.Domain, curve.Curve)
 	if err != nil {
 		t.Errorf("Could not hash message: %v\n", err)
 	}
@@ -142,7 +142,7 @@ func TestGeneral_GetTypedMessageHash(t *testing.T) {
 func TestGeneral_GetTypeHash(t *testing.T) {
 	tdd := MockTypedData()
 
-	hash, err := tdd.GetTypeHash("StarknetDomain")
+	hash, err := tdd.GetTypeHash("StarkNetDomain")
 	if err != nil {
 		t.Errorf("error enccoding type %v\n", err)
 	}
@@ -152,7 +152,7 @@ func TestGeneral_GetTypeHash(t *testing.T) {
 		t.Errorf("type hash: %v does not match expected %v\n", utils.BigToHex(hash), exp)
 	}
 
-	enc := tdd.Types["StarknetDomain"]
+	enc := tdd.Types["StarkNetDomain"]
 	if utils.BigToHex(enc.Encoding) != exp {
 		t.Errorf("type hash: %v does not match expected %v\n", utils.BigToHex(hash), exp)
 	}