Fixes linter and test errors

account/account_test.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"encoding/json"
 	"flag"
-	"fmt"
 	"math/big"
 	"os"
 	"testing"
@@ -18,7 +17,6 @@ import (
 	"github.com/NethermindEth/starknet.go/mocks"
 	"github.com/NethermindEth/starknet.go/rpc"
 	"github.com/NethermindEth/starknet.go/utils"
-	"github.com/joho/godotenv"
 	"github.com/stretchr/testify/require"
 	"go.uber.org/mock/gomock"
 )
@@ -43,18 +41,12 @@ var (
 //
 //	none
 func TestMain(m *testing.M) {
-	flag.StringVar(&testEnv, "env", "mock", "set the test environment")
+	flag.StringVar(&testEnv, "env", "devnet", "set the test environment")
 	flag.Parse()
 	if testEnv == "mock" {
 		return
 	}
-	base = os.Getenv("INTEGRATION_BASE")
-	if base == "" {
-		if err := godotenv.Load(fmt.Sprintf(".env.%s", testEnv)); err != nil {
-			panic(fmt.Sprintf("Failed to load .env.%s, err: %s", testEnv, err))
-		}
-		base = os.Getenv("INTEGRATION_BASE")
-	}
+	base = "http://localhost:5050"
 	os.Exit(m.Run())
 }
 
@@ -1076,7 +1068,7 @@ func TestWaitForTransactionReceipt(t *testing.T) {
 				Timeout:         3, // Should poll 3 times
 				Hash:            new(felt.Felt).SetUint64(100),
 				ExpectedReceipt: rpc.TransactionReceipt{},
-				ExpectedErr:     rpc.Err(rpc.InternalError, &rpc.RPCData{Message: "Post \"http://localhost:5050\": context deadline exceeded"}),
+				ExpectedErr:     rpc.Err(rpc.InternalError, &rpc.RPCData{Message: "context deadline exceeded"}),
 			},
 		},
 	}[testEnv]
@@ -1090,7 +1082,7 @@ func TestWaitForTransactionReceipt(t *testing.T) {
 			rpcErr, ok := err.(*rpc.RPCError)
 			require.True(t, ok)
 			require.Equal(t, test.ExpectedErr.Code, rpcErr.Code)
-			require.Equal(t, test.ExpectedErr.Data.Message, rpcErr.Data.Message)
+			require.Contains(t, rpcErr.Data.Message, test.ExpectedErr.Data.Message) // sometimes the error message starts with "Post \"http://localhost:5050\":..."
 		} else {
 			require.Equal(t, test.ExpectedReceipt.ExecutionStatus, (*resp).ExecutionStatus)
 		}

client/client.go

@@ -705,7 +705,7 @@ func (c *Client) read(codec ServerCodec) {
 		msgs, batch, err := codec.readBatch()
 		if _, ok := err.(*json.SyntaxError); ok {
 			msg := errorMessage(&parseError{err.Error()})
-			codec.writeJSON(context.Background(), msg, true)
+			_ = codec.writeJSON(context.Background(), msg, true)
 		}
 		if err != nil {
 			c.readErr <- err

client/client_test.go

@@ -427,7 +427,7 @@ func TestClientSubscribeInvalidArg(t *testing.T) {
 				t.Error(string(buf))
 			}
 		}()
-		client.EthSubscribe(context.Background(), arg, "foo_bar")
+		_, _ = client.EthSubscribe(context.Background(), arg, "foo_bar")
 	}
 	check(true, nil)
 	check(true, 1)
@@ -565,7 +565,7 @@ func TestUnsubscribeTimeout(t *testing.T) {
 	t.Parallel()
 
 	srv := NewServer()
-	srv.RegisterName("nftest", new(notificationTestService))
+	_ = srv.RegisterName("nftest", new(notificationTestService))
 
 	// Setup middleware to block on unsubscribe.
 	p1, p2 := net.Pipe()
@@ -637,7 +637,7 @@ func TestClientSubscriptionUnsubscribeServer(t *testing.T) {
 
 	// Create the server.
 	srv := NewServer()
-	srv.RegisterName("nftest", new(notificationTestService))
+	_ = srv.RegisterName("nftest", new(notificationTestService))
 	p1, p2 := net.Pipe()
 	recorder := &unsubscribeRecorder{ServerCodec: NewCodec(p1)}
 	go srv.ServeCodec(recorder, OptionMethodInvocation|OptionSubscriptions)
@@ -680,7 +680,7 @@ func TestClientSubscriptionChannelClose(t *testing.T) {
 	defer srv.Stop()
 	defer httpsrv.Close()
 
-	srv.RegisterName("nftest", new(notificationTestService))
+	_ = srv.RegisterName("nftest", new(notificationTestService))
 	client, _ := Dial(wsURL)
 	defer client.Close()
 
@@ -842,7 +842,9 @@ func TestClientReconnect(t *testing.T) {
 		if err != nil {
 			t.Fatal("can't listen:", err)
 		}
-		go http.Serve(l, srv.WebsocketHandler([]string{"*"}))
+		go func() {
+			_ = http.Serve(l, srv.WebsocketHandler([]string{"*"}))
+		}()
 		return srv, l
 	}
 

client/handler.go

@@ -163,7 +163,7 @@ func (b *batchCallBuffer) doWrite(ctx context.Context, conn jsonWriter, isErrorR
 	}
 	b.wrote = true // can only write once
 	if len(b.resp) > 0 {
-		conn.writeJSON(ctx, b.resp, isErrorResponse)
+		_ = conn.writeJSON(ctx, b.resp, isErrorResponse)
 	}
 }
 
@@ -173,7 +173,7 @@ func (h *handler) handleBatch(msgs []*jsonrpcMessage) {
 	if len(msgs) == 0 {
 		h.startCallProc(func(cp *callProc) {
 			resp := errorMessage(&invalidRequestError{"empty batch"})
-			h.conn.writeJSON(cp.ctx, resp, true)
+			_ = h.conn.writeJSON(cp.ctx, resp, true)
 		})
 		return
 	}
@@ -245,7 +245,7 @@ func (h *handler) handleBatch(msgs []*jsonrpcMessage) {
 		h.addSubscriptions(cp.notifiers)
 		callBuffer.write(cp.ctx, h.conn)
 		for _, n := range cp.notifiers {
-			n.activate()
+			_ = n.activate()
 		}
 	})
 }
@@ -261,7 +261,7 @@ func (h *handler) respondWithBatchTooLarge(cp *callProc, batch []*jsonrpcMessage
 			break
 		}
 	}
-	h.conn.writeJSON(cp.ctx, []*jsonrpcMessage{resp}, true)
+	_ = h.conn.writeJSON(cp.ctx, []*jsonrpcMessage{resp}, true)
 }
 
 // handleMsg handles a single non-batch message.
@@ -291,7 +291,7 @@ func (h *handler) handleNonBatchCall(cp *callProc, msg *jsonrpcMessage) {
 			cancel()
 			responded.Do(func() {
 				resp := msg.errorResponse(&internalServerError{errcodeTimeout, errMsgTimeout})
-				h.conn.writeJSON(cp.ctx, resp, true)
+				_ = h.conn.writeJSON(cp.ctx, resp, true)
 			})
 		})
 	}
@@ -303,11 +303,11 @@ func (h *handler) handleNonBatchCall(cp *callProc, msg *jsonrpcMessage) {
 	h.addSubscriptions(cp.notifiers)
 	if answer != nil {
 		responded.Do(func() {
-			h.conn.writeJSON(cp.ctx, answer, false)
+			_ = h.conn.writeJSON(cp.ctx, answer, false)
 		})
 	}
 	for _, n := range cp.notifiers {
-		n.activate()
+		_ = n.activate()
 	}
 }
 

client/http_test.go

@@ -110,7 +110,7 @@ func TestHTTPRespBodyUnlimited(t *testing.T) {
 
 	s := NewServer()
 	defer s.Stop()
-	s.RegisterName("test", largeRespService{respLength})
+	_ = s.RegisterName("test", largeRespService{respLength})
 	ts := httptest.NewServer(s)
 	defer ts.Close()
 

client/json.go

@@ -260,7 +260,7 @@ func (c *jsonCodec) writeJSON(ctx context.Context, v interface{}, isErrorRespons
 	if !ok {
 		deadline = time.Now().Add(defaultWriteTimeout)
 	}
-	c.conn.SetWriteDeadline(deadline)
+	_ = c.conn.SetWriteDeadline(deadline)
 	return c.encode(v, isErrorResponse)
 }
 
@@ -283,15 +283,15 @@ func (c *jsonCodec) closed() <-chan interface{} {
 func parseMessage(raw json.RawMessage) ([]*jsonrpcMessage, bool) {
 	if !isBatch(raw) {
 		msgs := []*jsonrpcMessage{{}}
-		json.Unmarshal(raw, &msgs[0])
+		_ = json.Unmarshal(raw, &msgs[0])
 		return msgs, false
 	}
 	dec := json.NewDecoder(bytes.NewReader(raw))
-	dec.Token() // skip '['
+	_, _ = dec.Token() // skip '['
 	var msgs []*jsonrpcMessage
 	for dec.More() {
 		msgs = append(msgs, new(jsonrpcMessage))
-		dec.Decode(&msgs[len(msgs)-1])
+		_ = dec.Decode(&msgs[len(msgs)-1])
 	}
 	return msgs, true
 }

client/log/handler.go

@@ -77,7 +77,7 @@ func (h *TerminalHandler) Handle(_ context.Context, r slog.Record) error {
 	h.mu.Lock()
 	defer h.mu.Unlock()
 	buf := h.format(h.buf, r, h.useColor)
-	h.wr.Write(buf)
+	_, _ = h.wr.Write(buf)
 	h.buf = buf[:0]
 	return nil
 }

client/log/logger.go

@@ -170,7 +170,7 @@ func (l *logger) Write(level slog.Level, msg string, attrs ...any) {
 	}
 	r := slog.NewRecord(time.Now(), level, msg, pcs[0])
 	r.Add(attrs...)
-	l.inner.Handler().Handle(context.Background(), r)
+	_ = l.inner.Handler().Handle(context.Background(), r)
 }
 
 func (l *logger) Log(level slog.Level, msg string, attrs ...any) {

client/server.go

@@ -67,7 +67,7 @@ func NewServer() *Server {
 	// Register the default service providing meta information about the RPC service such
 	// as the services and methods it offers.
 	rpcService := &RPCService{server}
-	server.RegisterName(MetadataApi, rpcService)
+	_ = server.RegisterName(MetadataApi, rpcService)
 	return server
 }
 
@@ -177,7 +177,7 @@ func (s *Server) serveSingleRequest(ctx context.Context, codec ServerCodec) {
 	if err != nil {
 		if msg := messageForReadError(err); msg != "" {
 			resp := errorMessage(&invalidMessageError{msg})
-			codec.writeJSON(ctx, resp, true)
+			_ = codec.writeJSON(ctx, resp, true)
 		}
 		return
 	}

client/server_test.go

@@ -90,15 +90,15 @@ func runTestScript(t *testing.T, file string) {
 		case strings.HasPrefix(line, "--> "):
 			t.Log(line)
 			// write to connection
-			clientConn.SetWriteDeadline(time.Now().Add(5 * time.Second))
+			_ = clientConn.SetWriteDeadline(time.Now().Add(5 * time.Second))
 			if _, err := io.WriteString(clientConn, line[4:]+"\n"); err != nil {
 				t.Fatalf("write error: %v", err)
 			}
 		case strings.HasPrefix(line, "<-- "):
 			t.Log(line)
 			want := line[4:]
 			// read line from connection and compare text
-			clientConn.SetReadDeadline(time.Now().Add(5 * time.Second))
+			_ = clientConn.SetReadDeadline(time.Now().Add(5 * time.Second))
 			sent, err := readbuf.ReadString('\n')
 			if err != nil {
 				t.Fatalf("read error: %v", err)
@@ -124,7 +124,9 @@ func TestServerShortLivedConn(t *testing.T) {
 		t.Fatal("can't listen:", err)
 	}
 	defer listener.Close()
-	go server.ServeListener(listener)
+	go func() {
+		_ = server.ServeListener(listener)
+	}()
 
 	var (
 		request  = `{"jsonrpc":"2.0","id":1,"method":"rpc_modules"}` + "\n"
@@ -137,10 +139,10 @@ func TestServerShortLivedConn(t *testing.T) {
 			t.Fatal("can't dial:", err)
 		}
 
-		conn.SetDeadline(deadline)
+		_ = conn.SetDeadline(deadline)
 		// Write the request, then half-close the connection so the server stops reading.
-		conn.Write([]byte(request))
-		conn.(*net.TCPConn).CloseWrite()
+		_, _ = conn.Write([]byte(request))
+		_ = conn.(*net.TCPConn).CloseWrite()
 		// Now try to get the response.
 		buf := make([]byte, 2000)
 		n, err := conn.Read(buf)

client/subscription.go

@@ -305,7 +305,7 @@ func (sub *ClientSubscription) run() {
 
 	// Call the unsubscribe method on the server.
 	if unsubscribe {
-		sub.requestUnsubscribe()
+		_ = sub.requestUnsubscribe()
 	}
 
 	// Send the error.

client/testservice_test.go

@@ -154,7 +154,7 @@ func (s *testService) CallMeBackLater(ctx context.Context, method string, args [
 	go func() {
 		<-ctx.Done()
 		var result interface{}
-		c.Call(&result, method, args...)
+		_ = c.Call(&result, method, args...)
 	}()
 	return nil
 }
@@ -214,7 +214,7 @@ func (s *notificationTestService) HangSubscription(ctx context.Context, val int)
 	subscription := notifier.CreateSubscription()
 
 	go func() {
-		notifier.Notify(subscription.ID, val)
+		_ = notifier.Notify(subscription.ID, val)
 	}()
 	return subscription, nil
 }

client/websocket.go

@@ -369,14 +369,14 @@ func (wc *websocketCodec) pingLoop() {
 
 		case <-pingTimer.C:
 			wc.jsonCodec.encMu.Lock()
-			wc.conn.SetWriteDeadline(time.Now().Add(wsPingWriteTimeout))
-			wc.conn.WriteMessage(websocket.PingMessage, nil)
-			wc.conn.SetReadDeadline(time.Now().Add(wsPongTimeout))
+			_ = wc.conn.SetWriteDeadline(time.Now().Add(wsPingWriteTimeout))
+			_ = wc.conn.WriteMessage(websocket.PingMessage, nil)
+			_ = wc.conn.SetReadDeadline(time.Now().Add(wsPongTimeout))
 			wc.jsonCodec.encMu.Unlock()
 			pingTimer.Reset(wsPingInterval)
 
 		case <-wc.pongReceived:
-			wc.conn.SetReadDeadline(time.Time{})
+			_ = wc.conn.SetReadDeadline(time.Time{})
 		}
 	}
 }