Refactor to use use unwrapErr() throughout the codebase #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stranger80
changed the title
|
@Bitcoinnoobie I took liberty to rename this PR for readability |
rianhughes
approved these changes
Sep 26, 2023
|
This issue should be resolved before this PR is merged. We should run tests on PRs |
|
There are a few places (other that the ones that were addressed) where no Could these be modified too? |
Also, this was already merged in, but in order to be applied to this PR I think it's necessary to fetch the latest changes from main into this branch |
cicr99
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with related to issue #318