-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore::> Derive public key from private key using crypto
package
#594
chore::> Derive public key from private key using crypto
package
#594
Conversation
@thiagodeev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @PsychoPunkSage! That's exactly what I had in mind.
But now, I believe we can do better. Sorry about that, but I'm going to ask you to take another approach.
Hmm, This approach will surely make things clean but don't you think it will be redundant?? |
This was also my first intention on this feature, but I realized that the MemKeyStore is not a simple privateKey pointer, is literally a "key store", that can store multiple keys and have multiple use cases. If we change it directly, users who are using this feature could be in trouble. |
Mmmm, |
@thiagodeev have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @PsychoPunkSage!
I'll ask one general thing: please put descriptions in the code (package, functions, and methods).
Besides that, I left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PsychoPunkSage, left some comments.
An observation: you need to put golang doc code comments
Hi @thiagodeev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PsychoPunkSage, left a few comments, otherwise looks good!
@thiagodeev |
Thanks @PsychoPunkSage! |
Hi @thiagodeev |
Addresses #590 pointer 4