Fix trace/simulation tests for sepolia #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianhughes
approved these changes
Oct 17, 2024
derrix060
reviewed
Oct 17, 2024
| @@ -182,7 +182,7 @@ | |||
| "range_check_builtin_applications": 121, | |||
| "ec_op_builtin_applications": 3, | |||
| "data_availability": { | |||
| "l1_gas": 4668, | |||
| "l1_gas": 4646, | |||
There was a problem hiding this comment.
looks like it should indeed be 4668: https://github.com/NethermindEth/starknet.go/actions/runs/11381954197/job/31664465265?pr=639#step:8:68
There was a problem hiding this comment.
oh I just saw Rian's comment now.
In this case we need to update the endpoint that starknet.go is using
There was a problem hiding this comment.
The endpoint under test is using a buggy version of Juno that doesn’t yet include the fix.
There was a problem hiding this comment.
We decided to hold off on merging it until the endpoint is updated with the new Juno version.
wojciechos
force-pushed
the
wojciechos/fix-simulate-test
branch
from
593313d to
e6cba1e
Compare
rianhughes
approved these changes
Oct 18, 2024
thiagodeev
pushed a commit
that referenced
this pull request
Dec 4, 2024
Update test data post Juno bug fix
thiagodeev
pushed a commit
that referenced
this pull request
Dec 19, 2024
Update test data post Juno bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the expected test data, which was previously based on invalid responses from Juno. The bug in Juno caused an overestimation leading to incorrect test expectations. The bug has been fixed in this PR, and this update corrects the test data to reflect the accurate responses after the fix.