-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anandpathak31/issue5 #6
Conversation
Corrected some typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some comments I have on the beginner tutorial, feel free to take or leave any of them, they're just suggestions.
|
||
## Plotting graphs | ||
|
||
We can plot graphs in Julia using the `Plots.jl` package. To add this package we use the terminal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should consider switching this to Makie
# Define the time variable | ||
@variables t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay to do this, but it might be a better idea to just use MTK's builtin t
and D
, i.e.
using ModelingToolkit: t_nounits as t, D_nounits as D
since that's the more recommended way of doing things nowadays, you'll have less clashing definitions of t
and D
floating around, but it's also not a big deal
|
||
```@example beginner_tutorial | ||
# Define the differential operator | ||
D = Differential(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
@variables t v(t) u(t) | ||
@parameters a b c d I | ||
D = Differential(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider switching to using ModelingToolkit: t_nounits as t, D_nounits as D
Co-authored-by: Mason Protter <mason.protter@icloud.com>
Co-authored-by: Mason Protter <mason.protter@icloud.com>
Co-authored-by: Mason Protter <mason.protter@icloud.com>
…eurobloxDocsHost into anandpathak31/issue5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
@harisorgn this PR is complete. I am not merging to avoid overwriting the master which might be ahead in commits. |
No description provided.