Revert "Work-around issues with the PetBar not accepting modified key… #156
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bindings" This reverts commit e79877f.
…ybinding The issue with modified petbar keybinds is still there, so I was a bit overhasty with my previous commit. I tried to improve the issue that the workaround breakes the keybinds when on a vehicle or drake. In these cases the keybinds of the petbar do not work.
zahnom
force-pushed
the
fix-petbar-keybindings
branch
from
c77186b to
e88510d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The keybindings for the pet bar don't work at all when in a vehicle or a drake (e.g. in occulus). When disabling Bartender the issue is gone. So the current problem is that
Root cause
Looks like the quick fix of e79877f now causes problems in Wotlk 3.4.1.47966. If I revert this commit everything works smooth again.Edit: I was a bit overhasty with reverting e79877f. The issue with the modified keybindings on the petbar reappears when reverting. The root cause for the petbar keybindings not working when on vehicle is the work-around of e79877f, though.
Solution
I don't have a definitive solution, but at least something that could improve the situation. I modified
PetBarMod:ReassignBindingsso that the work-around is only used for bindings with a modifier, and the "traditional" way is used for the others. As a result, the keybindings for pets work for both normal and modified bindings and when on a vehicle at least the normal keybindings work. Keybindings with modifiers still won't work when on a vehicle though. But I think it's worth adding this improvement to at least help all the people with non-modified keybindings on the petbar.