Preperations for collection updates #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al12rs
reviewed
Jan 23, 2025
| /// <summary> | ||
| /// Deletes a revision and all downloaded entities. | ||
| /// </summary> | ||
| public async ValueTask DeleteRevision(CollectionRevisionMetadataId revisionId) |
There was a problem hiding this comment.
I'm a bit confused as to why DeleteRevision and DeleteCollection methods are here in NexusMods.Networking.NexusWebApi, wouldn't it make more sense for this stuff to live somewhere in the DataModel or something?
There was a problem hiding this comment.
NexusModsLibrary has somewhat become the place for all these operations.
There was a problem hiding this comment.
I don't want to necessarily fix that in this PR, but would you agree that it shouldn't be that way?
There was a problem hiding this comment.
They could go into CollectionDownloader
There was a problem hiding this comment.
Want to move in separate PR?
Al12rs
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #391.