BUG: Character Creation - Resolved. Code Base Cleaned Up. REAMDE Cleaned Up and Updated. #15
Conversation
Bug fixing in Develop to push to main.
All BUGS worked out and Develop Finalized
add added DnD API and Character Sheet CSS to list of techs used in README.md
…eetshow.erikplachta.com, and add link to website on repo..
…se. Not complete but more so.
…g creation to crash due to DnD API API change in profs.
Resolved Bug with Character Creation
BUG Resolved: Character Creation Failing
|
@NicaVulcan - I'm not sure if you want to merge these changes, but I got the application working on Character Creation again and wanted to make sure you were aware. This merge contains A LOT more than just the BUG fix |
ErikPlachta
added
bug
…ionality in functioncreateAbilityScores(), cleaned up logic, add comments, verified works.
Resolved Bugs with Asset Mapping and Enabled/Verified AbilityScores are generating
Fixed Asset mapping. Enabled Ability Score generation.
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
Added a license
| @@ -1,41 +1,138 @@ | |||
| # The-Sheet-Show | |||
There was a problem hiding this comment.
Overhaul on README content and design.
| @@ -85,6 +85,11 @@ router.get('/:id', (req, res) => { | |||
|
|
|||
| // create hero | |||
| router.post('/', withAuth, (req, res) => { | |||
| /** CharacterCreator.js sends in payload from user input and D&D API | |||
There was a problem hiding this comment.
Made note of what this is doing while working on it.
| @import url('./animations.css'); | ||
| @import url('./login.css'); | ||
| @import url('./character-sheet-template.css'); | ||
| @import url('./hero-card.css'); | ||
| :root { |
There was a problem hiding this comment.
Importing all CSS to simplify / make it quicker to fix an issue.
| @@ -0,0 +1,115 @@ | |||
| // Retrieve selected race ability bonus info | |||
There was a problem hiding this comment.
I pulled this from the branch @NicaVulcan is working on knowing it will change, but I didn't want the app to be partially working.
| } | ||
|
|
||
| async function createAbilityScores () { | ||
| /** Manage calculating abilities scores when user clicks "Calculate" button. |
There was a problem hiding this comment.
Did some big cleanup on this function and enabled things
| for (let i = 0; i < array.length; i++) { | ||
| arr.push(array[i].index); | ||
|
|
||
| const get_nRandomProficiencies = function (array, n) { |
There was a problem hiding this comment.
Simplified this, added comments, and verified working.
This was the source of the Character Creation failure
| @@ -15,7 +15,8 @@ const loginFormHandler = async (event) => { | |||
| // alert('Login Success.'); | |||
| document.location.replace('/'); | |||
| } else { | |||
| alert('Failed to log in.'); | |||
| // console.log(response) | |||
| alert('Failed to log in. Please check username, password and try again.'); | |||
There was a problem hiding this comment.
Add more complete message for now
| @@ -2,6 +2,36 @@ | |||
| <form id="character-form"> | |||
| <h1>Character Creator</h1> | |||
|
|
|||
| <!-- Name input--> | |||
There was a problem hiding this comment.
Rearranged input order
| @@ -1,4 +1,4 @@ | |||
| <link href="//maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" rel="stylesheet" id="bootstrap-css"> | |||
There was a problem hiding this comment.
Removed Bootstrap as it's not needed
Taking down the app as i no longer want to work on it.
No description provided.