Skip to content

Commit

Permalink
workflows/codeowners: Dry mode for now
Browse files Browse the repository at this point in the history
Apparently it started requesting reviews from code owners already
because the DRY_MODE from the global env was overridden in the local job
declaration: #347354 (comment)
  • Loading branch information
infinisil committed Oct 9, 2024
1 parent 4f9b30c commit c1710f2
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/codeowners.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ on:
env:
# TODO: Once confirmed that this works by seeing that the action would request
# reviews from the same people (or refuse for wrong base branches),
# move all entries from CODEOWNERS to OWNERS and change this value here
# OWNERS_FILE: .github/OWNERS
# move all entries from CODEOWNERS to OWNERS, remove these two lines and uncomment the ones below
OWNERS_FILE: .github/CODEOWNERS
# Also remove this
DRY_MODE: 1
# OWNERS_FILE: .github/OWNERS
# # Don't do anything on draft PRs
# DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}

jobs:
# Check that code owners is valid
Expand Down Expand Up @@ -84,5 +85,3 @@ jobs:
run: result/bin/request-reviews.sh ${{ github.repository }} ${{ github.event.number }} "$OWNERS_FILE"
env:
GH_TOKEN: ${{ steps.app-token.outputs.token }}
# Don't do anything on draft PRs
DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}

0 comments on commit c1710f2

Please sign in to comment.